Skip to content

fix(core): better handling VMs with osType=Windows#2345

Merged
diafour merged 1 commit into
mainfrom
fix/core/tsc-labels-unschedulable
May 20, 2026
Merged

fix(core): better handling VMs with osType=Windows#2345
diafour merged 1 commit into
mainfrom
fix/core/tsc-labels-unschedulable

Conversation

@diafour
Copy link
Copy Markdown
Member

@diafour diafour commented May 13, 2026

Description

  1. More stable TSC labels to handle VMs with reenlightenment feature (mostly Windows guests).

See: deckhouse/3p-kubevirt#109

  1. Prevent stale labels with empty values on Nodes.

See: deckhouse/kube-api-rewriter#7 (merged by #2351)

  1. Another supportive PR: clenup cpu.features when Dicovery vmclass changed to non-Discovery

See: #2352

Why do we need it, and what problem does it solve?

CPU frequency drifts on Nodes may lead to "Unschedulable" and non-migratable VMs.

What is the expected result?

VMs with Windows guests starts and migrates.

Checklist

  • The code is covered by unit tests.
  • e2e tests passed.
  • Documentation updated according to the changes.
  • Changes were tested in the Kubernetes cluster manually.

Changelog entries

section: core
type: fix
summary: "Better handling Windows guests: start and migration should work in clusters with frequent CPU frequencies drifts"

@diafour diafour added this to the v1.9.0 milestone May 13, 2026
@diafour diafour changed the title fix(core): better handling osType: Windows VMs fix(core): better handling VMs with osType=Windows May 13, 2026
@diafour diafour force-pushed the fix/core/tsc-labels-unschedulable branch from e8c6d56 to 17359eb Compare May 19, 2026 08:47
@diafour diafour marked this pull request as ready for review May 19, 2026 08:47
@diafour diafour requested a review from Isteb4k as a code owner May 19, 2026 08:47
1) More stable TSC labels to handle VMs with reenlightenment feature (mostly Windows guests).

See: deckhouse/3p-kubevirt#109

2) Prevent stale labels with empty values on Nodes.

See: deckhouse/kube-api-rewriter#7
Signed-off-by: Ivan Mikheykin <ivan.mikheykin@flant.com>
@diafour diafour force-pushed the fix/core/tsc-labels-unschedulable branch from 17359eb to 66ba7cd Compare May 20, 2026 07:53
@diafour diafour merged commit e2cfb74 into main May 20, 2026
29 of 30 checks passed
@diafour diafour deleted the fix/core/tsc-labels-unschedulable branch May 20, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants