fix(vtex): add fast health response for k8s readiness probes#342
Open
fix(vtex): add fast health response for k8s readiness probes#342
Conversation
K8s probes hitting GET / were timing out because the runtime only handles /_healthcheck, leaving GET / to traverse the full middleware stack and return 404. Added a short-circuit before the runtime so probes get an immediate 200 OK. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
K8s readiness probes were failing with
context deadline exceededwhen hittingGET /on the VTEX MCP pod. The@decocms/runtimeonly handles/_healthcheckas a fast health path —GET /goes through the full middleware stack and returns 404, which either times out under the probe's deadline or fails with non-2xx. This adds a short-circuit invtex/server/main.tsthat returns200 OKimmediately forGET /before delegating to the runtime.Summary by cubic
Return a fast 200 OK for GET / in the VTEX server to keep K8s readiness/liveness probes from timing out. This short-circuits before
@decocms/runtimeand leaves other routes unchanged.Bug Fixes
vtex/server/main.tsthat responds "OK" toGET /./_healthcheckstays with@decocms/runtime.Refactors
oxfmtformatting across the repo (docs/configs), no behavior changes.Written for commit 7636bff. Summary will update on new commits.