Fix Wine installation#939
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e0a83d1dc3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| wget -q -O - "$(cat /run/secrets/DM_PACKAGES_URL)/${PS4_SDK_FILENAME}" | tar xz -C "${PS4_SDK}" --strip-components=1 | ||
|
|
||
| FROM europe-west1-docker.pkg.dev/extender-426409/extender-public-registry/extender-wine-env:1.7.0 | ||
| FROM europe-west1-docker.pkg.dev/extender-426409/extender-public-registry/extender-wine-env:1.7.1 |
There was a problem hiding this comment.
When server/build-docker.sh builds ps4, ps5, nintendo, or windows from scratch, it builds the wine target first but still tags it only as extender-wine-env:1.7.0 (checked server/build-docker.sh:80). This new FROM ...:1.7.1 therefore has no local image produced by the script, so a clean CI/release run will try to pull 1.7.1 from the registry and fail before that tag exists (or use an unrelated preexisting remote image). Please update the script to publish 1.7.1 before switching consumers to this tag.
Useful? React with 👍 / 👎.
1 participant
Fixes #936