Skip to content

Allow authentication v4#171

Merged
dereuromark merged 5 commits into
masterfrom
widen-auth-v4
May 25, 2026
Merged

Allow authentication v4#171
dereuromark merged 5 commits into
masterfrom
widen-auth-v4

Conversation

@dereuromark
Copy link
Copy Markdown
Owner

Summary

  • widen the dev constraint to allow v4
  • update the affected auth tests for the v4 identifier factory API
  • keep the branch green against the new major

Copilot AI review requested due to automatic review settings May 25, 2026 18:54
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 25, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.65%. Comparing base (1f4b5fb) to head (4a72044).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #171   +/-   ##
=========================================
  Coverage     77.65%   77.65%           
  Complexity      490      490           
=========================================
  Files            32       32           
  Lines          1311     1311           
=========================================
  Hits           1018     1018           
  Misses          293      293           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the development dependency constraints and test setup to support cakephp/authentication v4, aligning TinyAuth’s test suite with the new Identifier factory-based instantiation API while keeping compatibility with v3.

Changes:

  • Widen cakephp/authentication in require-dev to allow ^4.0 alongside ^3.0.1.
  • Update PrimaryKeySessionAuthenticatorTest to use Authentication\Identifier\IdentifierFactory instead of IdentifierCollection.
  • Adjust test property PHPDoc to reflect that a single IdentifierInterface is being passed to the authenticator.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tests/TestCase/Authenticator/PrimaryKeySessionAuthenticatorTest.php Switches test identifier construction to IdentifierFactory::create() to match Authentication v4 APIs.
composer.json Expands cakephp/authentication dev constraint to allow v4.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings May 25, 2026 18:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread tests/TestCase/Authenticator/PrimaryKeySessionAuthenticatorTest.php
Comment thread tests/TestCase/Authenticator/PrimaryKeySessionAuthenticatorTest.php Outdated
The PrimaryKeySessionAuthenticator test now holds a single IdentifierInterface
instance, so rename the misleading plural property to a singular name.
Copilot AI review requested due to automatic review settings May 25, 2026 23:01
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@dereuromark dereuromark merged commit 3311863 into master May 25, 2026
17 checks passed
@dereuromark dereuromark deleted the widen-auth-v4 branch May 25, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants