Allow authentication v4#171
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #171 +/- ##
=========================================
Coverage 77.65% 77.65%
Complexity 490 490
=========================================
Files 32 32
Lines 1311 1311
=========================================
Hits 1018 1018
Misses 293 293 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR updates the development dependency constraints and test setup to support cakephp/authentication v4, aligning TinyAuth’s test suite with the new Identifier factory-based instantiation API while keeping compatibility with v3.
Changes:
- Widen
cakephp/authenticationinrequire-devto allow^4.0alongside^3.0.1. - Update
PrimaryKeySessionAuthenticatorTestto useAuthentication\Identifier\IdentifierFactoryinstead ofIdentifierCollection. - Adjust test property PHPDoc to reflect that a single
IdentifierInterfaceis being passed to the authenticator.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/TestCase/Authenticator/PrimaryKeySessionAuthenticatorTest.php | Switches test identifier construction to IdentifierFactory::create() to match Authentication v4 APIs. |
| composer.json | Expands cakephp/authentication dev constraint to allow v4. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The PrimaryKeySessionAuthenticator test now holds a single IdentifierInterface instance, so rename the misleading plural property to a singular name.
Summary