Skip to content

ci(codeql): remove the duplicate CodeQL workflow, keep the GitHub default setup - #11

Merged
lukisch merged 2 commits into
mainfrom
chore/remove-duplicate-codeql
Nov 7, 2026
Merged

lukisch merged 2 commits into
mainfrom
chore/remove-duplicate-codeql

Conversation

@lukisch

@lukisch lukisch commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

What

T-20261107-558181168. The CodeQL / analyze check is red on every run (push to main c381595, pull requests, the weekly schedule), not caused by any PR: "advanced configurations cannot be processed when the default setup is enabled". The repository has two CodeQL configurations:

  • the GitHub default setup, read-only check via gh api repos/dev-bricks/CareCenter-for-Codex/code-scanning/default-setup: state: configured, languages actions and python, query suite default, schedule weekly, configured since 2026-07-22 (its analyses are green);
  • the own workflow .github/workflows/codeql.yml (python only, added 2026-10-30), an advanced configuration, which GitHub rejects while the default setup is on.

This PR removes the workflow and keeps the default setup (the recommendation of the ticket): less maintenance, nothing is lost because the default setup already covers Python and, in addition, GitHub Actions. The contract test in tests/test_metadata.py that required the file now forbids it and any github/codeql-action step; a CHANGELOG entry explains the decision.

Not done on purpose: switching the repository to the advanced setup would be a repository setting of the owner. If that is ever wanted, change the setting first and add the workflow in the same step.

Check of other repositories (read-only)

Of the 262 local clones, 10 (8 distinct GitHub repositories) have an own CodeQL workflow. code-scanning/default-setup there: clirec, decision-clicker, ellmos-unified-gui, session-checkpoint, swarm_ai are not-configured (no double configuration); ellmos-core and ellmos-delegation-authority answer "Advanced Security must be enabled" (private, no default setup possible); odysseus is a third-party repository (no access). So CareCenter-for-Codex is the only affected repository among them. The count covers the clones of this host only, no full scan.

Tests

Red first (1e23798: test_codeql_runs_through_the_github_default_setup_only fails because the file exists), then the removal. tests/test_metadata.py, tests/test_docs_contracts.py, tests/test_security_license_contract.py: 57 passed. ruff check clean.

Separate from #10 (the TOML fix) on purpose: CI configuration against runtime code, different risk, independent revert.

🤖 Generated with Claude Code

https://claude.ai/code/session_01THB2EysTVQFXz5moenpBvW

Lukas Geiger and others added 2 commits November 7, 2026 17:40
…setup only

The repository has the GitHub default setup for code scanning (python, actions, weekly, default
suite, configured since 2026-07-22). The own workflow .github/workflows/codeql.yml is a second
configuration: its analyze job fails on every run with 'advanced configurations cannot be
processed when the default setup is enabled' (push to main c381595, pull request, schedule).
The old contract test required the file; the new one forbids it and any codeql-action step.

Fails against c381595 (codeql.yml exists).

Refs: T-20261107-558181168

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01THB2EysTVQFXz5moenpBvW
…ault setup

T-20261107-558181168. The GitHub default setup for code scanning is configured for this
repository (languages python and actions, weekly, default suite, since 2026-07-22). The own
workflow added on 2026-10-30 is a second configuration; its analyze job failed on every run
(push to main c381595, pull request, schedule) with "advanced configurations cannot be processed
when the default setup is enabled". The default setup already covers Python and GitHub Actions,
so no coverage is lost. The contract test that required the file now forbids it.

The red test of 1e23798 passes; tests/test_metadata.py, test_docs_contracts.py and
test_security_license_contract.py: 57 passed.

Refs: T-20261107-558181168

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01THB2EysTVQFXz5moenpBvW
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown

Welcome! 👋 Thanks for your first pull request in this repository.

A maintainer will review it soon. Please make sure:

  • Your changes are tested
  • Documentation is updated if needed
  • The PR description explains what and why

Thanks for contributing!

@lukisch
lukisch merged commit 28e49b2 into main Nov 7, 2026
7 checks passed
@lukisch

lukisch commented Nov 7, 2026

Copy link
Copy Markdown
Contributor Author

Independent review at aadf043, from a session that is not the author. Merged (squash). The code-scanning default setup is configured for python and actions (weekly, default suite; read via the API), so removing .github/workflows/codeql.yml loses no coverage and ends the failing analyze job ("advanced configurations cannot be processed when the default setup is enabled"), which failed identically on main. The new contract test test_codeql_runs_through_the_github_default_setup_only fails with the old workflow restored and passes without it. No other github/codeql-action step is left under .github/. All checks are green on this head. Independent review by Claude Opus 5.5 (claude-opus-5-5); posted with the owner's account, so this is a comment, not a formal review.

lukisch pushed a commit that referenced this pull request Nov 7, 2026
Holt #11 (CodeQL-Workflow entfernt) in den Branch, damit der rote analyze-Check
(Advanced-Workflow gegen Default Setup) auf diesem PR verschwindet. Einziger Konflikt:
CHANGELOG.md, beide Eintraege unter Unreleased bleiben erhalten. Ohne Force-Push.

Geprueft im Merge-Stand: pytest 579 passed, 6 skipped; ruff check sauber.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01THB2EysTVQFXz5moenpBvW
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant