Repository navigation
Conversation
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
A commit can be shown on another site as a card that reads like /dev/null:
the commit, the commit it quotes, optionally the rest of its author's
thread, and its replies down to several levels, with the same header,
body, polls, link previews, actions row, tombstones and rail, drawn by the
app's own components. The card is served live, so a deletion, a rejection
or an opt-out shows on every page that embeds it.
- Users and organizations can turn embeds off in their settings; they are
on by default, exported and erased with the account. Cards then read
[unavailable], like any commit that can't be shown.
- /embed/{uuid} serves the card: signed, framable, sessionless, always the
guest view, readable without JavaScript. Its links are plain links to
/dev/null: nothing is prefetched or previewed on hover.
- embed.js sizes the frame to the card, and /oembed describes the signed
commit link to blogging platforms.
- "Embed commit" in the commit's menu opens a dialog that previews the
card and hands out HTML, Markdown and a link, signed for members only.
See dev-null-sh#1521 for the RFC.
jubianchi
force-pushed
the
feat/commit-embeds
branch
from
November 9, 2026 22:48
478d7a7 to
3a4df7d
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
An implementation of the commit embeds described in #1521, so the RFC can be discussed on something that runs. This is a draft: the design is open for discussion in the issue, and this PR will follow what is decided there.
Changes
[unavailable]./embed/{uuid}. The card is signed, framable and sessionless, and reads without JavaScript. It shows the commit, the commit it quotes, its thread and its replies, drawn with the commit page's own components (CommitHeader,GraphRail,ReplyBranch,CommitPoll,QuotedCommit,TombstoneLine…). It is read-only, and its links are plain links: nothing is prefetched or previewed on hover.embed.jsand/oembed.embed.jssizes the frame./oembedreturns the card for the signed commit link.Validation
StandaloneCommitGraphs, which also fails onproductionsince #1454tsc, lintVisual evidence
More screenshots, in light and dark, are in #1521. They predate the last design pass, so the card's header and the quoted commit look slightly different now.
Device verification
Tested in desktop Chrome on macOS, in light and dark, and on a page 420px wide. Not checked on a phone.
Independent review
An automated adversarial review ran locally; this is not a human review. Its findings on what the card exposes and on its links are fixed. The others are listed under Limitations.
Limitations
429fallback;createRootinstead of hydrating the server's HTML.app/Support→app/Services.KNOWLEDGE_BASE.md,DESIGN.md,PRODUCT.md.