Repository navigation
Conversation
GET /api/v1/commits/{commit}/replies always sent up to 50 replies and
ignored limit. It now takes limit from 1 to 50, as the web's replies
endpoint does, and keeps 50 as the default. The cursor links keep the limit.
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/v1/commits/{commit}/repliesalways sends up to 50 replies and ignoreslimit. The mobile app shows a thread's replies ten at a time (NativePHP/dev-null-app#179), so it fetches 50 and throws most away. The web's replies endpoint already takeslimit.Changes
ListApiCommitRepliesRequestacceptslimitfrom 1 to 50, the same rule asListCommitRepliesRequest, and the controller passes it toCommitRepliesQuery::paginate(). 50 stays the default.withQueryString()already carrieslimitonto the next cursor link. One sentence inKNOWLEDGE_BASE.mdunder the signed API.Validation
Local, PHP 8.5.12, PostgreSQL with its own test database:
vendor/bin/pint --teston the changed files: passphpstan: pass, no errorstests/Feature/Controllers/Api/CommitReplyControllerTest.phpandtests/Feature/Controllers/CommitReplyControllerTest.php: pass. New tests cover a page of 10, the next page keeping the limit, and 0, 51 and a non-number getting422.--ci: 6126 tests, 6107 passed and 19 failed. All 19 are intests/Feature/CommitScriptTest.phpand fail the same way on unchangedproductionhere (the shell script sandbox doesn't run on this machine), so they are not from this change. The suite ran with all three of my API PRs merged together.Independent review
A read-only Claude review agent with the repo's
.ai/guidelinesand the diff againstproductionat 2ef29e7, head 9494578: CODE: PASS.Limitations
None.