Repository navigation
feat: show paginated guild members - #1598
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
There was a problem hiding this comment.
🟡 Changes recommended
Offset pagination can skip or duplicate guild members when memberships change between Load more requests, requiring stable pagination and regression coverage for joins and departures.
1 open issue
What changed in this PR
Adds browsable guild member lists to the existing guild preview, accessible from member counts on the overview and guild boards.
Changes:
- Adds an authenticated, feature-gated endpoint with moderator-first ordering and 50-member pagination.
- Adds a members page with profile links, manual Load more, and support for paused and empty guilds.
- Adds regression tests and updates the knowledge base.
| File | Description |
|---|---|
tests/Feature/Controllers/GuildMembershipControllerTest.php |
Tests ordering, pagination, privacy, access controls, and empty states. |
routes/web.php |
Registers the guild members endpoint. |
resources/js/pages/guild/members.tsx |
Displays members with profile links and Load more. |
resources/js/components/guild-preferences.tsx |
Makes guild member counts clickable. |
KNOWLEDGE_BASE.md |
Documents browsing guild members. |
app/Http/Requests/ListGuildMembersRequest.php |
Enforces feature access and validates page numbers. |
app/Http/Controllers/GuildMembershipController.php |
Returns ordered, paginated members with explicit public fields. |
Review effort: Balanced
| 'users' => Inertia::scroll(fn () => $guild->members() | ||
| ->orderByRaw('(users.id = ?) desc nulls last', [$guild->user_id]) | ||
| ->orderByPivot('joined_at', 'desc')->latest('users.id') | ||
| ->paginate(50)->through(fn (User $member): array => [ |

Summary
Make guild member counts clickable on the Guilds overview and guild boards. They open a members page with 50 people per page and Load more for subsequent pages.
The moderator appears first with
(moderator)after their name, followed by members ordered by newest join. Paused guilds retain their browsable member lists.Changes
Validation
composer test:lint— passed; existing unrelated JavaScript lint warnings remain.composer test:types— passed.composer test:type-coverage— passed, 100%.bun run test:unit— 321 passed.php -d memory_limit=-1 vendor/bin/pest --parallel --ci --coverage --exactly=100.0 --passthru-php="'-d' 'memory_limit=-1'"— 6,125 passed, 33,580 assertions, 100% coverage.php -d memory_limit=-1 vendor/bin/pest --ci tests/Feature/Controllers/GuildMembershipControllerTest.php— 5 passed, 76 assertions.bun run buildandgit diff --check— passed./guilds/rust/members. No browser errors or horizontal overflow. Layout-shift observer recorded no entries for fresh load, navigation or pagination. Keyboard Enter on the overview's zero-member link opened the empty list.Independent review
Independent read-only review: CODE PASS · VISUAL PASS, with no blockers, for base d27f6a3 and head eca201c. The reviewer inspected all seven changed files, ten screenshots, both interaction recordings, and the supplied verification logs. Tests and builds were not independently rerun; exact DOM counts, URL and CLS measurements, keyboard navigation and narrow-screen scrolling remain implementer-verified. The list contains joined members: the moderator is prioritized when joined, without synthesizing membership for a moderator who has left.
Limitations
Text-only PR using
.github/PULL_REQUEST_TEMPLATE/without-media.md; inspection captures remain in the development thread. Linux Chromium viewport emulation is not a physical-device or iOS/Android simulator test. Native keyboards, browser chrome and safe areas are unverified; this change adds no text inputs. No deployment or production data changes.Summary by CodeRabbit