Skip to content

feat: show paginated guild members - #1598

Merged
paulinevos merged 1 commit into
productionfrom
feat/guild-members
Nov 17, 2026
Merged

paulinevos merged 1 commit into
productionfrom
feat/guild-members

Conversation

@paulinevos

@paulinevos paulinevos commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Make guild member counts clickable on the Guilds overview and guild boards. They open a members page with 50 people per page and Load more for subsequent pages.

The moderator appears first with (moderator) after their name, followed by members ordered by newest join. Paused guilds retain their browsable member lists.

Changes

  • Add a feature-gated members endpoint using the existing membership relationship and explicit public member fields; mute-only preferences and other guilds' members are not listed.
  • Reuse profile links, avatars, lane colors and manual Inertia pagination. Preserve the canonical URL and reserve loading-spinner space.
  • Add regression coverage for moderator ordering, tied join dates, the 50-person boundary, excluded preferences, private fields, paused/empty lists, authentication, feature access and page validation.
  • Update the knowledge base.

Validation

  • composer test:lint — passed; existing unrelated JavaScript lint warnings remain.
  • composer test:types — passed.
  • composer test:type-coverage — passed, 100%.
  • bun run test:unit — 321 passed.
  • php -d memory_limit=-1 vendor/bin/pest --parallel --ci --coverage --exactly=100.0 --passthru-php="'-d' 'memory_limit=-1'" — 6,125 passed, 33,580 assertions, 100% coverage.
  • php -d memory_limit=-1 vendor/bin/pest --ci tests/Feature/Controllers/GuildMembershipControllerTest.php — 5 passed, 76 assertions.
  • bun run build and git diff --check — passed.
  • Linux Chromium at 1440×900, 1366×650 and 390×844, light and dark: inspected normal, long-name, empty and exhausted states. Moderator appears first with the suffix; long names truncate. The narrow layout can scroll to the final row above the bottom navigation.
  • Real-pointer navigation and Load more: 50 rows became 52 unique rows, the exhausted button disappeared, and the canonical URL stayed /guilds/rust/members. No browser errors or horizontal overflow. Layout-shift observer recorded no entries for fresh load, navigation or pagination. Keyboard Enter on the overview's zero-member link opened the empty list.
  • No polling or text inputs were added. Physical device and native keyboard/browser-chrome behavior were not verified.

Independent review

Independent read-only review: CODE PASS · VISUAL PASS, with no blockers, for base d27f6a3 and head eca201c. The reviewer inspected all seven changed files, ten screenshots, both interaction recordings, and the supplied verification logs. Tests and builds were not independently rerun; exact DOM counts, URL and CLS measurements, keyboard navigation and narrow-screen scrolling remain implementer-verified. The list contains joined members: the moderator is prioritized when joined, without synthesizing membership for a moderator who has left.

Limitations

Text-only PR using .github/PULL_REQUEST_TEMPLATE/without-media.md; inspection captures remain in the development thread. Linux Chromium viewport emulation is not a physical-device or iOS/Android simulator test. Native keyboards, browser chrome and safe areas are unverified; this change adds no text inputs. No deployment or production data changes.

Summary by CodeRabbit

  • New Features
    • Guild member counts now open a dedicated member list, showing the moderator first, followed by members who joined most recently.
    • Browse members in pages of 50 using Load more. Member profiles include avatars, names, handles, and available bios.
    • Guild member lists are available to signed-in users when the guilds preview is enabled.
  • Documentation
    • Updated the guilds preview guide with details about browsing members and pagination.

Copilot AI balanced review requested due to automatic review settings November 17, 2026 14:21
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The change adds an authenticated, paginated guild member listing. The member-count control links to the listing, which displays member profiles and supports loading additional pages. The documentation describes the member order and page size.

Changes: Guild Member Listing

Layer / File(s) Summary
Authorize and serve member pages
app/Http/Requests/ListGuildMembersRequest.php, routes/web.php, app/Http/Controllers/GuildMembershipController.php, tests/Feature/Controllers/GuildMembershipControllerTest.php
The request checks Guilds feature access and validates the page parameter. The route calls the controller, which returns members ordered with the moderator first and then newest joins, paginated by 50. Tests cover ordering, pagination, returned fields, and access.
Link to and render member pages
resources/js/components/guild-preferences.tsx, resources/js/pages/guild/members.tsx, KNOWLEDGE_BASE.md
The member count links to the listing. The page displays member profiles and a Load more control when more results are available. The documentation describes the listing and ordering.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant GuildMemberCount
  participant GuildMembershipIndex
  participant GuildMembershipController
  participant MembersPage
  GuildMemberCount->>GuildMembershipIndex: Open guild members link
  GuildMembershipIndex->>GuildMembershipController: Route GET request
  GuildMembershipController->>MembersPage: Render paginated member data
Loading

Possibly related issues

Possibly related PRs

Suggested reviewers: mnapoli, nunomaduro

Merge Risk: Minimal · up to eca20

This adds a paginated guild member list reachable from the member count, gated by the Guilds feature and sign-in. No blocking risk was found, so it looks ready to merge.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "feat: show paginated guild members" matches the main change: a feature-gated, paginated member list for guilds, reached from clickable member counts. It is concise, uses the conventional co…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "feat: show paginated guild members" matches the main change: a feature-gated, paginated member list for guilds, reached from clickable member counts. It is concise, uses the conventional commit prefix, and names the primary change. The title does not mention the feature gate or the link from member counts, but those details are secondary.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 3d095cfa-3f57-427c-b9d9-9b11949cd154
Commits

Reviewing files that changed from the base of the PR and between d27f6a3 and eca201c.

Files selected for processing: 7

  • KNOWLEDGE_BASE.md
  • app/Http/Controllers/GuildMembershipController.php
  • app/Http/Requests/ListGuildMembersRequest.php
  • resources/js/components/guild-preferences.tsx
  • resources/js/pages/guild/members.tsx
  • routes/web.php
  • tests/Feature/Controllers/GuildMembershipControllerTest.php

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 2 remain after this review.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Offset pagination can skip or duplicate guild members when memberships change between Load more requests, requiring stable pagination and regression coverage for joins and departures.

1 open issue
What changed in this PR

Adds browsable guild member lists to the existing guild preview, accessible from member counts on the overview and guild boards.

Changes:

  • Adds an authenticated, feature-gated endpoint with moderator-first ordering and 50-member pagination.
  • Adds a members page with profile links, manual Load more, and support for paused and empty guilds.
  • Adds regression tests and updates the knowledge base.
File Description
tests/​Feature/​Controllers/​GuildMembershipControllerTest.php Tests ordering, pagination, privacy, access controls, and empty states.
routes/​web.php Registers the guild members endpoint.
resources/​js/​pages/​guild/​members.tsx Displays members with profile links and Load more.
resources/​js/​components/​guild-preferences.tsx Makes guild member counts clickable.
KNOWLEDGE_BASE.md Documents browsing guild members.
app/​Http/​Requests/​ListGuildMembersRequest.php Enforces feature access and validates page numbers.
app/​Http/​Controllers/​GuildMembershipController.php Returns ordered, paginated members with explicit public fields.

Review effort: Balanced

'users' => Inertia::scroll(fn () => $guild->members()
->orderByRaw('(users.id = ?) desc nulls last', [$guild->user_id])
->orderByPivot('joined_at', 'desc')->latest('users.id')
->paginate(50)->through(fn (User $member): array => [

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meh. ship it

@paulinevos
paulinevos merged commit 173bf55 into production Nov 17, 2026
16 checks passed
@paulinevos
paulinevos deleted the feat/guild-members branch November 17, 2026 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants