Skip to content

fix: keep the search guild banner in step with the search box - #1601

Merged
paulinevos merged 1 commit into
dev-null-sh:productionfrom
kachelle:fix/search-guild-banner-query
Nov 17, 2026
Merged

paulinevos merged 1 commit into
dev-null-sh:productionfrom
kachelle:fix/search-guild-banner-query

Conversation

@kachelle

@kachelle kachelle commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

The "Create a guild" banner on search now follows the search box: removing the # hides it and typing a hashtag shows it right away. Before, it shared key={query} with the result tabs, so old banners were never removed and stacked up.

Visual evidence

Local, signed in, after searching #laravel, then #vue, then vue.

Before After
Desktop light
Desktop dark
Phone

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Bug Fixes
    • The hashtag-guild banner now updates as you edit the search box, reflecting its current trimmed text rather than the last submitted query.

The banner and the result tabs were siblings keyed by the same query, so React never removed old banners and they stacked up. The banner now follows the search box, so removing or typing a hashtag hides or shows it right away.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The hashtag-guild banner now follows the trimmed search-box draft. The component no longer uses the submitted query as a remounting key.

Changes: Search draft banner

Layer / File(s) Summary
Use the draft term for hashtag matching
resources/js/pages/search/index.tsx
HashtagGuild now accepts term and applies hashtag matching and handle normalization to the trimmed draft. The component no longer uses the submitted query as its key.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

Suggested reviewers: paulinevos

Merge Risk: Minimal · up to 2773e

The search banner now follows what the user types, appearing when a hashtag is entered and disappearing when it is removed. This fixes the stacked stale banners. No merge-blocking risk was found.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title names the main change: the search page's guild banner now tracks the search box draft instead of the submitted query, which fixes stale or duplicated banners. The raw summary and objectives …
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title names the main change: the search page's guild banner now tracks the search box draft instead of the submitted query, which fixes stale or duplicated banners. The raw summary and objectives both describe this same change to resources/js/pages/search/index.tsx, so the title is fully related to the changeset.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: e4db691f-e3c3-4c34-98d9-0ebf9ac9151c
Commits

Reviewing files that changed from the base of the PR and between 173bf55 and 2773e12.

Files selected for processing: 1

  • resources/js/pages/search/index.tsx

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@kachelle
kachelle marked this pull request as ready for review November 17, 2026 16:14
@paulinevos
paulinevos merged commit 0eabad2 into dev-null-sh:production Nov 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants