Skip to content

feat: find guilds from the Cmd+K search - #1603

Open
kachelle wants to merge 1 commit into
dev-null-sh:productionfrom
kachelle:feat/command-palette-guilds
Open

kachelle wants to merge 1 commit into
dev-null-sh:productionfrom
kachelle:feat/command-palette-guilds

Conversation

@kachelle

@kachelle kachelle commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Cmd+K now finds guilds by handle or name, under a Guilds heading after Organizations, and opens the guild page. It filters the guilds prop members already have, so there's no extra request, and guests or users without the guilds feature see none.

Visual evidence

Local, signed in, after typing remote in Cmd+K.

Before After
Desktop light
Desktop dark
Phone light
Phone dark

🤖 Generated with Claude Code

Summary by CodeRabbit

  • New Features
    • Search results now include matching guilds, with their icon, name, handle, and optional description, and link to each guild’s page.
    • Guild searches match handles and names regardless of capitalization, support a leading #, and show the most relevant results first.
    • Topic searches show up to two guilds; guilds are excluded when picking developers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The search dialog now includes matching guilds in its results. Guild matching ranks handle and name matches, applies a result limit, and handles empty and prefixed search terms. Guild results display identifying details and link to the guild page.

Changes: Guild search

Layer / File(s) Summary
Guild matching and tests
resources/js/lib/guild-search.ts, tests/Unit/GuildSearch.test.ts
matchGuilds ranks handle and name matches, sorts by rank and member count, and applies a result limit. Unit tests cover matching, ordering, limits, and empty results.
Search dialog guild results
resources/js/components/search-dialog.tsx
The dialog adds eligible guild matches to search options, groups them under “Guilds,” and renders them with a link to the guild page. Topic searches include at most two guild results. Developer-picking mode excludes guilds.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant SearchDialog
  participant matchGuilds
  participant optionsFor
  participant GuildController
  participant GuildResult
  SearchDialog->>matchGuilds: Search guilds using the term
  matchGuilds-->>SearchDialog: Return ranked guild matches
  SearchDialog->>optionsFor: Pass guild matches
  optionsFor-->>SearchDialog: Return guild options
  SearchDialog->>GuildController: Open selected guild by handle
  SearchDialog->>GuildResult: Render guild option
Loading

Possibly related PRs

Suggested reviewers: nunomaduro, paulinevos

Merge Risk: Minimal · up to a82a6

Guild search in Cmd+K is gated server-side, so members without the feature see no guild results. No merge-blocking risk remains.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title "feat: find guilds from the Cmd+K search" matches the main change. The diff adds guild results to the Cmd+K search dialog, with a new matchGuilds helper and unit tests. The title is short, s…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title "feat: find guilds from the Cmd+K search" matches the main change. The diff adds guild results to the Cmd+K search dialog, with a new matchGuilds helper and unit tests. The title is short, specific, and states the primary feature.

Finishing Touches

Generate unit tests (beta)

  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: a4e40b50-fb74-4711-93ee-bed348c13250
Commits

Reviewing files that changed from the base of the PR and between 00c4fed and a82a610.

Files selected for processing: 3

  • resources/js/components/search-dialog.tsx
  • resources/js/lib/guild-search.ts
  • tests/Unit/GuildSearch.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

@kachelle
kachelle marked this pull request as ready for review November 17, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant