Skip to content

fix(rulesets): let the next Platform merge group validate early - #893

Merged
devantler merged 1 commit into
mainfrom
codex/platform-queue-builds-892
Nov 11, 2026
Merged

devantler merged 1 commit into
mainfrom
codex/platform-queue-builds-892

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Why

Platform pull requests can sit for hours before their merge-group checks start. The queue currently starts only one group at a time.

What

Let two groups validate at once. Each merge still contains one pull request and requires all checks.

Fixes #892

⚠️ Merge order — land and verify devantler-tech/platform#6036 first so production keeps deploying in queue order.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@codex review for ruleset ownership, single-entry merges, required checks, and guarded rollout order

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T23:14:29.509691Z 434f5a3 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: 434f5a354e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@github-code-quality

github-code-quality Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Code coverage overview

Languages: C#, Go

C# / code-coverage/dotnet

main 8d40663 codex/platform-queue... 434f5a3 +/-
100% 100% 0%

Go / code-coverage/go

main 0042076 codex/platform-queue... 434f5a3 +/-
50% 50% 0%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.


Updated November 11, 2026 00:01 UTC

@devantler

devantler commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Blocker cleared 2026-11-11: devantler-tech/platform#6036 merged at 07:05Z, and the first merge group built on it (platform#6037, run 42977006972) deployed and succeeded at 07:2xZ, so production keeps deploying in queue order.

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

Readiness at 434f5a354e

  • Merge order: satisfied. platform#6036 merged and its first merge group (platform#6037) deployed and succeeded with the new ordering preflight.
  • Tried as a user: this changes one setting on the Platform merge-queue ruleset; the ruleset test renders the manifest and asserts the full queue configuration (two groups built, one PR merged per group, every required check kept), and passes at this head. Nothing else consumes the file.
  • Review: Codex reviewed this exact head, no findings. 0 review threads.
  • Hygiene: all checks green, merge state CLEAN.

Promoting. After it reconciles, the Platform queue should start the second entry's checks while the first is still validating.

@devantler
devantler marked this pull request as ready for review November 11, 2026 07:28
@devantler
devantler merged commit 933b536 into main Nov 11, 2026
215 checks passed
@devantler
devantler deleted the codex/platform-queue-builds-892 branch November 11, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable two overlapping Platform merge-group builds

1 participant