Repository navigation
Closed
Copy link
Description
Goal
Make agents detect privacy implications automatically during requirements, design, code review and delivery, without claiming to provide definitive legal advice.
Research scope
GDPR and Danish Data Protection Act; Datatilsynet/EDPB primary guidance. Cover roles (controller/processor), lawful basis, data minimization, retention/deletion, access/export, data subject rights, DPIA screening, breach handling, processor agreements/subprocessors, international transfers, privacy by design and audit evidence. Distinguish legal obligations from engineering recommendations and mark uncertain interpretations for human approval.
Mandatory adoption-first workflow
- Inventory existing first-party skills and identify precise gaps; avoid duplication.
- Search reputable maintained third-party skills first. Evaluate quality, license/redistribution, security, compatibility, maintenance, provenance and scope.
- Prefer adopting a suitable upstream skill with an immutable version/commit pin and a reviewable automated update process; upstream changes must be summarized and tested before bumping the pin. Align with existing issues Bundled upstream skills: reviewable updates and clear redistribution terms #581, Updater PRs state what changed upstream for each moved skill #583 and Review and safely release the temporary git-commit upstream pin #598 rather than duplicating their implementation.
- Only author a new first-party skill when documented evaluation shows no adequate candidate. Before implementation, research authoritative standards, primary sources, realistic scenarios, failure modes, acceptance tests and maintenance ownership.
- Author first-party skills using the repository's skill-authoring skill and applicable Agent Skills specification/industry conventions; validate metadata, progressive disclosure, triggering, examples and automated evaluation. Never silently claim legal compliance.
Acceptance criteria
- Reuse evaluation and source-linked gap analysis documented before building.
- Triggers for contact forms, analytics, customer accounts, hosting and personal-data storage.
- Concrete checklists, evidence outputs, escalation points and tested positive/negative scenarios.
- Official sources dated and maintenance/review plan included.
Reacted by coderabbitai
Metadata
Metadata
Assignees
Labels
No labels
Type
Fields
Priority
None yet
Start date
None yet
Target date
None yet
Effort
None yet
Projects
- StatusShow more project fields✅ Done
Activity
coderabbitai commentedon Nov 4, 2026
🔗 Related PRs
#590 - ci: scope engineering-practice skill updates [closed]
📝 Issue Planner
Check the box below or use the
@coderabbitai plancommand to generate an implementation plan and prompts that you can use with your favorite coding assistant.🧪 Issue enrichment is currently in open beta.
You can configure auto-planning by selecting labels in the issue_enrichment configuration.
To disable automatic issue enrichment, add the following to your
.coderabbit.yaml:💬 Have feedback or questions? Drop into our discord!
docs: record skill coverage across the portfolio (#655)
devantler commentedon Nov 10, 2026
Research brief
Gap. Nothing tells an agent to notice that a change touches personal data, which questions that raises, which of them are legal duties and which are engineering preferences, and when a person has to decide.
Evidence. No incident is on record. The evidence is repeated work: each of these had to work out the same questions from nothing.
Where it shows up. Contact handling, customer identity and invoices in the business-site portal; guest replies in wedding-app; client sites; any product that adds analytics or a new hosting provider.
Acceptance scenarios.
application-security. "Write the cookie banner text" -> Add Danish business, consumer and accessibility compliance guidance #639. "A customer's data leaked" ->incident-response, with this skill for the reporting clock.uservariable".Already covered by.
application-securitycovers who may reach data and tenant isolation.incident-responsecovers the response to an incident. Nothing covers purpose, legal basis, retention, people's rights, processors, transfers or impact assessments.Would something else fix it better? Each product's own instructions must say which data it holds and who is accountable, and no skill replaces that. A CI check cannot know why data is collected. The questions to ask are the reusable part, so a skill is the right carrier.
Out of scope. Legal advice and any statement that something is compliant. Cookie and marketing-consent rules, consumer law and accessibility (#639). Access control (
application-security).Decision record: build
privacy-engineeringCandidates. Reviewed 2026-11-10.
gdpr-compliant227949a7(the skill last changed 2026-03-30)compliance-checke605d8ddPrivacy-Data-Protection-Skillssecpriv-skill70e1269aeyesecurity/skillsWhat was read.
gdpr-compliant: the whole entry file, and its folder listing for the references.compliance-check: the whole file.secpriv-skill: the opening of the file and the repository layout. The other two were not read; they fail before content matters.Why build. No candidate separates legal duties from recommendations, none covers Danish law, and the closest one fails on correctness.
Sources the skill is written against (checked 2026-11-10): the GDPR's own text; the Danish Data Protection Act as consolidated in act no. 289 of 8 March 2024, read in the official legal database; and the Danish Data Protection Agency's published guidance on secure transmission (updated 2025-10-17), breach handling (May 2025) and impact assessments. One fact changed against common belief while checking: the Danish age for a child's own consent to online services is now 15, not 13.
Known defects. None yet: the skill is being written. It will carry its sources, the date each was checked, and a review plan.
Description cost. Reported on the pull request, with the target of 400 characters or fewer.
Acceptance scenarios. Results are recorded on the pull request after the skill is installed from its head.
What would change this decision. A maintained upstream skill that separates law from practice and covers EU and Danish rules would replace this one.
🤖 Generated with Claude Code
fix(agentic-engineering): correct the privacy-engineering skill after…
fix(agentic-engineering): label authority practice and split one mixe…
fix(agentic-engineering): keep advice out of the law bullet in privac…
fix(agentic-engineering): address the review of the privacy and Danis…
feat(agentic-engineering): add the privacy-engineering and danish-bus…
devantler commentedon Nov 11, 2026
Done in #683, released as
agentic-engineering7.6.0. This note completes the decision record above.Acceptance criteria.
What changed during trial and review. The skill at first gave no way to finish the legal-basis step for health data and steered away from consent; both were fixed. The review added prior consultation with the authority, the exception to breach reporting, legal claims as a ground for keeping data, identifiers in audit logs, and the difference between a processor and another recipient. One fact I had wrong from memory was caught by reading the act: the Danish age for a child's own consent online is 15.
Description cost. 408 characters.
Known limits. It is engineering guidance, not legal advice, and it has not been reviewed by a lawyer. The Danish authority's list of processing that always needs an impact assessment is pointed to, not restated, because I could not read the file here. The review fixes were not re-tried by the fresh agent. Whether agents load the skill in daily work is for #651 to measure.
🤖 Generated with Claude Code