Skip to content

ci: move the release and template-sync callers to .github v21.0.0 - #366

Merged
devantler merged 1 commit into
mainfrom
claude/template-sync-v21
Nov 11, 2026
Merged

devantler merged 1 commit into
mainfrom
claude/template-sync-v21

Conversation

@devantler

Copy link
Copy Markdown
Contributor

Why

The shared template-sync workflow used to report success when it could not fetch the template, so a broken sync looked like "nothing to update". That was fixed in devantler-tech/.github#891 and released, but this site still runs the older version, and no site has run the fixed one yet. devantler-tech/.github#887 stays open until one does.

What

The release and template-sync callers move together from v20.1.7 to v21.0.0, as this repository's pin contract requires. Between those versions the release workflow did not change at all, and the sync workflow gained only that fix. The breaking change in v21.0.0 concerns the .NET test action, which this site does not use. The application publisher pin is not touched.

After the merge I start one template sync by hand and record the result on devantler-tech/.github#887.

Part of devantler-tech/.github#887

🤖 Generated with Claude Code

The sync workflow gains the fix that fails a run whose template pull
failed (devantler-tech/.github#891); the release workflow is unchanged
between the two versions.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The release and template-sync workflows now reference the reusable workflow revision at commit a27e1b3d6c2d2b528b4996cfff72cf0f5995b922 (v21.0.0), replacing the v20.1.7 revision. Their other settings remain unchanged.

Merge Risk: Minimal · up to df60c

Both workflow callers move to v21.0.0. No merge-blocking issue is identified.

Pre-merge checks: Passed 4

Check name Status Explanation
Title check Passed The title clearly and concisely identifies the main change: updating the release and template-sync callers to .github v21.0.0.
Description check Passed The description directly explains the workflow version updates, the template-sync fix, compatibility considerations, and follow-up validation.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 449a8f3e-2a91-4c02-b30c-1c0ecd45dce3
Commits

Reviewing files that changed from the base of the PR and between bccb470 and df60c93.

Files selected for processing: 2

  • .github/workflows/release.yaml
  • .github/workflows/template-sync.yaml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Recent review details

Additional comments: 2

.github/workflows/release.yaml: 1

14-14: LGTM!

.github/workflows/template-sync.yaml: 1

23-23: LGTM!

@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer (interactive Claude Code session)

What was tried at df60c937154f8f958f5050ba9508c3b4fdad236c, and what can only be tried after the merge

  • The repository's pin contract passes with the two callers on the new commit, and still rejects its 17 broken variants (scripts/workflow-caller-pin-contract.test.sh, locally and in CI).
  • I compared the two shared workflows between v20.1.7 and v21.0.0: the release workflow is identical, and the sync workflow differs only by the fix from fix(template-sync): fail the run when the template pull fails .github#891.
  • The sync itself runs only from the default branch with the repository's App key, so it cannot be tried from this branch. Right after the merge I start one sync by hand and post its result here and on Fail template sync when its source pull fails .github#887. If that run fails, I move the two pins back in a follow-up pull request.

🤖 Generated with Claude Code

@devantler
devantler marked this pull request as ready for review November 11, 2026 07:12
@devantler
devantler requested a review from a team as a code owner November 11, 2026 07:12
@devantler
devantler merged commit c83fcf7 into main Nov 11, 2026
26 checks passed
@devantler
devantler deleted the claude/template-sync-v21 branch November 11, 2026 07:12
@devantler

Copy link
Copy Markdown
Contributor Author

🤖 Generated by the Agentic Engineer (interactive Claude Code session)

Result of the sync runs after the merge

The pins stay on v21.0.0, and devantler-tech/.github#887 is closed with these two runs as evidence.

🤖 Generated with Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant