Repository navigation
Conversation
…orage-adopt-v1-benchmark-runtime-5665
…orage-adopt-v1-benchmark-runtime-5665
Contributor
Author
Validation at
Current-head hosted checks and substantive review remain required. After protected delivery, fresh deployed policy/type-checking and image binding readback precede the separate runtime rollout. That rollout also requires the recovery, memory headroom and volume-health gates in #6073. This preparation does not establish runtime adoption, benchmark acceptance or V2 migration. |
Contributor
✅
|
Contributor
✅
|
Code coverage overviewLanguages: Go Go / code-coverage/go
Line coverage data for the main branch is not yet available. View coverage of the 10 most covered files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. Updated |
Contributor
Author
@coderabbitai review |
Contributor
Action not completed
|
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
Contributor
Author
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
devantler
added a commit
that referenced
this pull request
Nov 11, 2026
Contributor
Author
Readiness at The current revision passed the complete affected migration package again with race detection in 61.008 seconds, including the real Kubernetes admission evaluator. The approved patched image is admitted only within the existing narrow controller boundary; the superseded and unapproved images remain refused. The current independent guard job 130743980551 in CI run 43083289967 also passed the corrected policy fingerprint and its negative controls. The earlier renderer and both 878-file schema validations cover the unchanged policy expression and authorization ledger. All 85 current-head checks have settled: 69 successful, 15 intentionally skipped and the rate-limited CodeRabbit result neutral. Codex's current-head receipt is 6806419431. Complete conversation, review, inline-comment and thread reads found no unresolved review finding or maintainer direction. GitHub currently reports CLEAN and mergeable. The configured Code Quality rule remains opaque to the gate helper; its two native analysis jobs succeeded, and this is not a claim of complete dependency extraction coverage. This prepares admission only. The Helm runtime image is unchanged. After protected delivery, deployed policy/type-checking and exact image binding must be read back before the separate runtime adoption in #6073, which retains its recovery, headroom and volume-health gates. No instance-manager restart, benchmark acceptance or V2 activation is established here. |
devantler
marked this pull request as ready for review
November 11, 2026 20:52
devantler
added this pull request to the merge queue
Nov 11, 2026
Any commits made after this event will not be merged.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The storage migration needs the patched temporary runtime, but its preparation still names the older build. That would prevent the replacement from starting correctly.
What
Prepare admission for the published patched runtime and remove the superseded build from that exception. Runtime rollout follows separately after the remaining recovery and capacity prerequisites.
Part of #6073