Skip to content

feat(run-script): soft-depend on add-script to enforce install order#268

Merged
sebst merged 2 commits intomainfrom
copilot/ensure-add-script-installed-first
Apr 1, 2026
Merged

feat(run-script): soft-depend on add-script to enforce install order#268
sebst merged 2 commits intomainfrom
copilot/ensure-add-script-installed-first

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 1, 2026

When both add-script and run-script are used together, there's no guarantee add-script is installed first. Adding it as a soft dependency via installsAfter ensures correct ordering without forcing add-script to be installed when only run-script is used.

Changes

  • src/run-script/devcontainer-feature.json — added add-script to installsAfter; bumped version 1.1.21.2.0
  • README.md — updated run-script version in the feature table
"installsAfter": [
    "ghcr.io/devcontainer-community/devcontainer-features/ca-certificates:latest",
    "ghcr.io/devcontainer-community/devcontainer-features/add-script:latest"
]

installsAfter is a soft dependency: the ordering is enforced only when both features are present in a user's devcontainer.json.

Original prompt

For feature "run-script", make sure the feature "add-script" is always installed before "run-script". Also make sure "add-script" is NOT a hard dependency of "run-script".

In other words: if a user installs both, run-script, and add-script, then add-script should always be installed first.

If a user only installs run-script, add-script should not be installed.

For changes that you make to achieve this, bump minor version of the feature.

Copilot AI changed the title [WIP] Update installation order for run-script feature feat(run-script): soft-depend on add-script to enforce install order Apr 1, 2026
Copilot AI requested a review from sebst April 1, 2026 07:34
Copilot finished work on behalf of sebst April 1, 2026 07:34
@sebst sebst marked this pull request as ready for review April 1, 2026 07:35
@sebst sebst merged commit db83992 into main Apr 1, 2026
3 checks passed
@sebst sebst deleted the copilot/ensure-add-script-installed-first branch April 1, 2026 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants