Conversation
Owner
devcrocod
commented
May 12, 2026
devcrocod
commented
- fixes Fails on unrecognized directives #23
- fixes fqn resolution
- output file resolution
parseDirective now requires both a `<!---` prefix AND a `-->` close on the same line, and only accepts the four known directive names (`IMPORT`, `FUN`, `FUNS`, `END`). Anything else — `<!---TODO-->`, `<!---TOC -->`, three-dash HTML comments, or an unclosed opener like `<!---FUN x` — returns null and passes through as text. Previously such lines either threw `IllegalArgumentException` from a `require` check (unhandled, surfaced as a confusing Gradle stack trace) or emitted noisy `Unrecognized directive` warnings. Also drops a latent bug where the lazy `.+?` value matcher could grab the closing `-->` into the value group. Adds an `unknownDirectives` integration fixture covering TODO/TOC/FIXME/ generic-comment lines, a 3-dash close, and an unclosed opener alongside a real FUN that still expands.
… and add integration fixture for samples outputs
…re to validate behavior
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.