ci: fix fixture dir discovery#292
Conversation
87e0bd4 to
c7db2fc
Compare
|
Context: I'm currently adding the package to nixpkgs. These 2 problems make an infinite loop in the nixpkgs build. |
|
I don't know how to fix that failing pr title validation job though 😅 |
|
I don't I love this approach because I've never seen a workflow that aliases the repo name when checking out the repo. You can't keep the name as |
There's plenty of workflow that don't keep the repo name.
I'm not sure I fully understand this, but then maybe the best way would be to use an explicit relative path, like |
The reason why I don't do this is because in local development (in IPython in vscode), |
What command/script are you using to reproduce this behavior? I've never seen anything like it, and the documentation says that |
As an example, this is how I develop all my code, interactively with an IPython/Jupyter pane on the right side. It doesn't update the Screen.Recording.2026-04-06.at.4.31.46.PM.mov |
|
Perhaps the best solution is just to put a |
|
Oh I see, interesting. That being said, file is wrong outside of test methods, but should be ok when really executing tests right? If I'm right, maybe it's an acceptable tradeoff?
Yes, I can do that, or look for a file that is at the root like |
It's correctly set when running tests through the python interpreter; just not from interactive mode.
Well, when I'm debugging tests I run the test files interactively as I showed above, so it would be annoying to have to manually override the path to fixtures every time I want to debug a test.
Yeah that sounds fine |
In some build environment (ex: the nixpkgs build system), the working copy / untared source are at `source/`, not `async-tif/`. Moreover, this also adds a stop condition to avoid infinite loop in case the fixtures dir is not there for whatever reason.
c7db2fc to
b1cb472
Compare
|
@kylebarron I've pushed another version detecting |
|
I merged in main to test #297 and see if the commit labeling works... which it looks like it does! |
|
Thanks again! And thanks for working on packaging! |
|
Thanks to have taken the time to find a solution for everyone! |
Description
The current conftest is walking the fs hierarchy up until it finds an
async-tifffolder. There is 2 problems with this approach:async-tiff. For instance thenixpkgsbuild system unpacks it in asource/dirThis commit finds a folder names
fixtures/instead and add a bulletproof stop condition (I hope).Note: I haven't tested on windows, and actually, I think it may be better to just hardcode the path like so:
(Path(__file__).parent.parent / "fixtures").resolve(). What do you think?