Repository navigation
feat: polish the install script and the progress spinner - #264
Merged
Merged
Conversation
install.sh now prints a short banner and groups its output into stages (resolve, download, verify, install) in the same ⏺/⎿ tree the CLI uses, with a separate "next steps" block at the end. Colours are only used on a real terminal, and are off with NO_COLOR or TERM=dumb. It stays POSIX sh and wrapped in main(). The spinner now uses cyan braille frames instead of clack's magenta ones, drops the │ guide bar, and ends with the CLI's own ✓ / ✗ symbols. A new ux.action.fail() marks failures. The CI fallback is unchanged apart from those symbols. Closes #90 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #90.
install.sh
⏺/⎿tree as the CLI.✓for steps that worked, dim text for secondary details, a yellow!for the shadowing-install warning, and a red✗ error:for errors.dcd loginanddcd --help.NO_COLORis set orTERMisdumb, and then the text is the same with no escape codes.sh(dash -nis clean) and is still wrapped inmain(). Thecurl --progress-bardownload is unchanged.Example output (colour removed):
Progress spinner (
src/utils/progress.ts)⠋⠙⠹…) instead of clack's magenta◒◐◓◑. Terminals without Unicode get ASCII frames.│guide bar. The CLI is a⏺/⎿tree, not a clack session.✓/✗, not clack's◇. The newux.action.fail()marks a failure. The upload, Moropo and results-polling call sites now use it, and no longer put their own✓/✗in the message.·instead of—.✓/✗on the final line.Testing
pnpm lint,pnpm typecheckandpnpm test:unitpass. The newtest/unit/progress.test.tscovers the non-interactive path.install.shfor real underdashwith output piped, under a pseudo-terminal with colour, and withNO_COLORon a failing download.🤖 Generated with Claude Code