Repository navigation
feat(upload): record APK CPU architectures in binary metadata - #269
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Every APK upload now records which CPU types the APK can run on. The fields go in the upload metadata, which the API already copies onto the
binariesrow.metadata.abis: the native ABI folders underlib/<abi>/, sorted. For example["arm64-v8a", "x86_64"].metadata.architectures:["arm"],["x86"]or["arm", "x86"].Rules
armeabi,armeabi-v7aandarm64-v8acount as arm.x86andx86_64count as x86.architecturesis["arm", "x86"]andabisis empty.riscv64,mips) are ignored.Limits
Testing
apkAbisandapkArchitectures, and the extractor tests updated for the wikipedia fixture (arm + x86).pnpm test:unit(469 passing),pnpm lint,pnpm typecheck.🤖 Generated with Claude Code