Repository navigation
chore(deps): override minimatch to 11.0.1 and glob to 14.0.2 - #287
Merged
Merged
Conversation
GHSA-g3hv-75wg-m249 (minimatch <11.0.1) and GHSA-3g3m-2fjr-6pw4 (glob >=9.0.0 <=14.0.1) are both moderate, so the CI audit fails on every branch. Both reach us only through dev tools: minimatch through eslint and mocha, glob through mocha. The patched versions are new majors, so they are pinned by override; lint, the unit suite and the build all pass on them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Code reviewSkipped the full review: this PR only changes dev dependencies. It adds two pnpm overrides in 🤖 Generated with Claude Code |
1 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pnpm audit --audit-level moderatefails on every branch because of two new moderate advisories:minimatchbelow 11.0.1. We had 10.2.6 through eslint and 10.2.3 through mocha.glob9.0.0 to 14.0.1. We had 13.0.6 through mocha.Both are dev-only, so nothing in the published CLI changes.
The patched versions are new majors, which eslint's and mocha's own ranges don't allow. So they're pinned with pnpm overrides, as with the earlier
qsandhonopins:minimatch@>=10.0.0 <11.0.1→11.0.1(replaces the old<10.2.3→10.2.3pin)glob@>=9.0.0 <14.0.2→14.0.2(new)Checked locally on the new versions:
pnpm audit --audit-level moderate(exit 0; one low advisory remains, inserialize-javascriptthrough mocha),pnpm lint,pnpm test:unit(514 passing) andpnpm build.🤖 Generated with Claude Code