Skip to content

fix(device): keep iOS 17, iPhone 16 Pro and iPhone 16 Pro Max in the … #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finalerock44 merged 1 commit into from
Nov 2, 2026
Merged

fix(device): keep iOS 17, iPhone 16 Pro and iPhone 16 Pro Max in the … #290

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/types/domain/device.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ export enum EiOSDevices {
'ipad-pro-m5-13' = 'ipad-pro-m5-13',
'iphone-14' = 'iphone-14',
'iphone-16' = 'iphone-16',
'iphone-16-pro' = 'iphone-16-pro',
'iphone-16-pro-max' = 'iphone-16-pro-max',
'iphone-17' = 'iphone-17',
'iphone-18-pro' = 'iphone-18-pro',
'iphone-18-pro-max' = 'iphone-18-pro-max',
Expand All @@ -39,6 +41,7 @@ export enum EAndroidDevices {

export enum EiOSVersions {
'eighteen' = '18',
'seventeen' = '17',
'twentySeven' = '27',
'twentySix' = '26',
}
Expand Down
6 changes: 3 additions & 3 deletions test/unit/device-validation.service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import type { CompatibilityData } from '../../src/utils/compatibility.js';
*/
const compat: CompatibilityData = {
ios: {
'iphone-14': ['18'],
'iphone-14': ['17', '18'],
'iphone-16': ['18', '26', '27'],
'iphone-17': ['26', '27'],
'iphone-19': ['28'],
Expand Down Expand Up @@ -117,7 +117,7 @@ describe('DeviceValidationService', () => {

it('rejects an unsupported explicit pair with the device\'s versions', () => {
expect(() => ios('27', 'iphone-14')).to.throw(
/^iphone-14 only supports these iOS versions: 18$/,
/^iphone-14 only supports these iOS versions: 17, 18$/,
);
expect(() => android('34', 'pixel-10')).to.throw(
/^pixel-10 only supports these Android API levels: 36, 37$/,
Expand All @@ -136,7 +136,7 @@ describe('DeviceValidationService', () => {
describe('requests that rely on a default', () => {
it('tells a device-only iOS request to pass the version explicitly', () => {
expect(() => ios(undefined, 'iphone-14')).to.throw(
'iphone-14 only supports these iOS versions: 18. No iOS version was given, so the default (26) was checked: pass one of those explicitly with --ios-version',
'iphone-14 only supports these iOS versions: 17, 18. No iOS version was given, so the default (26) was checked: pass one of those explicitly with --ios-version',
);
});

Expand Down
Loading