Skip to content

fix(install): reject a DCD_VERSION that isn't a release version #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
finalerock44 merged 1 commit into from
Nov 4, 2026
Merged

fix(install): reject a DCD_VERSION that isn't a release version #296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,11 @@ No stable dcd release is available yet.
}
}

# Only a release version goes into the download URLs below.
if ($version -cnotmatch '^v?[0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z.]+)?\z') {
throw "Invalid version '$version'. Use a release version such as 5.0.0 or 5.0.0-beta.1."
}

$url = "$DownloadBase/download/$version/$asset"
$sumsUrl = "$DownloadBase/download/$version/SHA256SUMS"

Expand Down
14 changes: 14 additions & 0 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,16 @@ no_stable_release_err() {
exit 1
}

# A release version: 5.0.0 or 5.0.0-beta.1 (a leading v is fine). The case
# check comes first because grep matches line by line, so it would accept a
# value with a newline in it on its first line alone.
valid_version() {
case "$1" in
'' | *[!0-9A-Za-z.-]*) return 1 ;;
esac
printf '%s\n' "$1" | grep -Eq '^v?[0-9]+\.[0-9]+\.[0-9]+(-[0-9A-Za-z.]+)?$'
}

# Find a dcd on PATH other than the one we just installed — usually a leftover
# `npm install -g @devicecloud.dev/dcd` that can shadow this binary. Runs in a
# subshell so the temporary IFS change never leaks back to the caller.
Expand Down Expand Up @@ -224,6 +234,10 @@ main() {
detail "${CYAN}${version}${RESET} ${DIM}(latest ${channel})${RESET}"
fi

# Only a release version goes into the download URLs below.
valid_version "$version" \
|| err "Invalid version '$version'. Use a release version such as 5.0.0 or 5.0.0-beta.1."

url="$DOWNLOAD_BASE/download/${version}/${asset}"
sums_url="$DOWNLOAD_BASE/download/${version}/SHA256SUMS"

Expand Down
Loading