Repository navigation
fix(device): a start that got no answer says a session may still have… - #297
Merged
Merged
Conversation
… started
`dcd device start` printed a bare error when POST /device/sessions got no
answer (a network error) or a proxy's 502 in the API's place. The API may
have created the session anyway, and it is billed while it runs, so running
the command again could leave two.
When the outcome is unknown, the error now says so first and lists the open
sessions started in the last 2 minutes (the one in the --json envelope's
session when there is exactly one), with how to check or stop them, or says
it is safe to start again. The API's own errors (its { statusCode, message }
envelope) still come through unchanged: those are refusals made before any
session exists.
The recent-session lookup moves into DeviceGateway.recentlyStarted, shared
with the MCP bridge's explanation of a failed start_device.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… started
dcd device startprinted a bare error when POST /device/sessions got no answer (a network error) or a proxy's 502 in the API's place. The API may have created the session anyway, and it is billed while it runs, so running the command again could leave two.When the outcome is unknown, the error now says so first and lists the open sessions started in the last 2 minutes (the one in the --json envelope's session when there is exactly one), with how to check or stop them, or says it is safe to start again. The API's own errors (its { statusCode, message } envelope) still come through unchanged: those are refusals made before any session exists.
The recent-session lookup moves into DeviceGateway.recentlyStarted, shared with the MCP bridge's explanation of a failed start_device.
What & why
Type of change
fix— bug fixfeat— new featureperf— performance improvementrefactor— code change that's neither a fix nor a featuredocs— documentation onlychore/ci/build/test— tooling, no user-facing change!or PR notes aBREAKING CHANGE:)Checklist
pnpm lintpassespnpm typecheckpassespnpm buildpassesCHANGELOG.md(release-please handles this)README.md/STYLE_GUIDE.mdupdated if behaviour or output changedHow to test