Repository navigation
feat: drop iPhone 16 Pro Max and gpu1 from help text (removed 9 Nov 2026) - #302
Merged
Merged
Conversation
…026) iphone-16-pro-max and the gpu1 runner type are removed on 9 November 2026. iphone-16-pro stays supported. - --ios-device help no longer lists iphone-16-pro-max. Validation already follows the live compatibility data, so the API's answer is what a run that names it gets. - --runner-type help, its error for an unknown value, and the dcd_run_cloud_test runnerType schema list default, m4, m1 and cpu1 only. - gpu1 is still accepted by --runner-type and by dcd_run_cloud_test, so scripts and agents that pass it keep working: the API runs it on cpu1. validateEnum takes an optional list of accepted values it leaves out of its error message, and the MCP schema's enum is overridden through zod metadata.
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iPhone 16 Pro Max and the
gpu1runner type were removed on 9 November 2026. iPhone 16 Pro stays, deprecated, with removal now targeted for 7 December 2026.--ios-devicehelp no longer listsiphone-16-pro-max. Validation was already driven by the live compatibility data, so the API's rejection is what users see.--runner-typehelp, its "expected one of" error and thedcd_run_cloud_testMCP schema now offerdefault, m4, m1, cpu1.gpu1is still accepted and sent as-is, so existing scripts keep working: the API runs it on cpu1 and its notice and submit warning say so.validateEnumgains an optional list of accepted-but-unlisted values.test/unit/runner-type.test.ts(6 tests).Gates:
pnpm lint(0 errors),pnpm typecheck,pnpm build,pnpm test:unit(531 passing).No release needed for the removal itself: it ships in the next beta.