Implement tap options (repeat, delay, retryTapIfNoChange, waitToSettleTimeoutMs)#53
Open
Implement tap options (repeat, delay, retryTapIfNoChange, waitToSettleTimeoutMs)#53
Conversation
…eTimeoutMs) Add executor-level tap option handling that wraps driver.Execute() for TapOnStep, DoubleTapOnStep, and LongPressOnStep. All 5 drivers benefit automatically with no driver-side changes. - repeat/delay: loop taps with configurable delay between them - retryTapIfNoChange: compare UI hierarchy before/after, retry if unchanged - waitToSettleTimeoutMs: poll hierarchy until stable before/after tap Matches Maestro's execution semantics. Fixes #52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
repeat,delay,retryTapIfNoChange, andwaitToSettleTimeoutMstap options that were parsed from YAML but ignored during executiondriver.Execute()— all 5 drivers (uiautomator2, wda, devicelab, appium, cdp) benefit with zero driver changeswaitForSettlepollsHierarchy()until two consecutive snapshots match, matching Maestro's behaviorTest plan
repeat: 3, delay: 1000should show visible delay between tapsFixes #52