-
Notifications
You must be signed in to change notification settings - Fork 7
Refactor Docker Compose file naming to avoid V2 precedence conflict #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
58b61f1
refactor: rename Docker Compose files to avoid V2 precedence conflict…
devondragon 4f448dc
docs: update CHANGELOG.md with Docker Compose refactor (#68)
devondragon 9ef2559
fix: address Copilot review feedback on compose refactor (#68)
devondragon a538671
chore: standardize MariaDB version to 12.2 across all compose files (…
devondragon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| # Local Development Database Configuration | ||
| # WARNING: These credentials are for LOCAL DEVELOPMENT ONLY. | ||
| # Production deployments MUST use secure credentials managed through | ||
| # environment variables or secrets management systems. | ||
|
|
||
| services: | ||
| mariadb: | ||
| image: mariadb:12.2 | ||
| environment: | ||
| MARIADB_DATABASE: springuser | ||
| MARIADB_USER: springuser | ||
| MARIADB_PASSWORD: springuser | ||
| MARIADB_ROOT_PASSWORD: rootpassword | ||
| ports: | ||
| - "3306:3306" | ||
| volumes: | ||
| - mariadb-data:/var/lib/mysql | ||
|
|
||
| volumes: | ||
| mariadb-data: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,20 +1,91 @@ | ||
| # Local Development Database Configuration | ||
| # WARNING: These credentials are for LOCAL DEVELOPMENT ONLY. | ||
| # Production deployments MUST use secure credentials managed through | ||
| # environment variables or secrets management systems. | ||
|
|
||
| services: | ||
| mariadb: | ||
| myapp-db: | ||
| image: mariadb:12.2 | ||
| container_name: springuser-db | ||
| volumes: | ||
| - userdb:/var/lib/mysql | ||
| environment: | ||
| MARIADB_DATABASE: springuser | ||
| MARIADB_USER: springuser | ||
| MARIADB_PASSWORD: springuser | ||
| MARIADB_ROOT_PASSWORD: rootpassword | ||
| MYSQL_ROOT_PASSWORD: root | ||
| MYSQL_DATABASE: springuser | ||
| MYSQL_USER: springuser | ||
| MYSQL_PASSWORD: springuser | ||
| MYSQL_TCP_PORT: 3306 | ||
| ports: | ||
| - "3306:3306" | ||
| healthcheck: | ||
| test: [ "CMD", "healthcheck.sh", "--connect", "--innodb_initialized" ] | ||
| start_period: 1m | ||
| start_interval: 10s | ||
| interval: 1m | ||
| timeout: 5s | ||
| retries: 3 | ||
|
|
||
| mailserver: | ||
| image: docker.io/mailserver/docker-mailserver:latest | ||
| container_name: springuser-mail | ||
| hostname: mailserver | ||
| domainname: local | ||
| env_file: mailserver.env | ||
| ports: | ||
| - "25:25" | ||
| - "587:587" | ||
| volumes: | ||
| - mariadb-data:/var/lib/mysql | ||
| - maildata:/var/mail | ||
| - mailstate:/var/mail-state | ||
| - maillogs:/var/log/mail | ||
| - ./config/:/tmp/docker-mailserver/${SELINUX_LABEL} | ||
| environment: | ||
| PERMIT_DOCKER: connected-networks | ||
| ONE_DIR: 1 | ||
| DMS_DEBUG: 0 | ||
| SPOOF_PROTECTION: 0 | ||
| REPORT_RECIPIENT: 1 | ||
| ENABLE_SPAMASSASSIN: 0 | ||
| ENABLE_CLAMAV: 0 | ||
| ENABLE_FAIL2BAN: 1 | ||
| ENABLE_POSTGREY: 0 | ||
| SMTP_ONLY: 1 | ||
| cap_add: | ||
| - NET_ADMIN | ||
| - SYS_PTRACE | ||
| healthcheck: | ||
| test: ["CMD", "nc", "-z", "localhost", "25"] | ||
| interval: 30s | ||
| timeout: 10s | ||
| retries: 5 | ||
|
|
||
| myapp-main: | ||
| image: spring-user-framework-demo | ||
| container_name: springuser-app | ||
| build: | ||
| context: . | ||
| dockerfile: Dockerfile | ||
| depends_on: | ||
| myapp-db: | ||
| condition: service_healthy | ||
| mailserver: | ||
| condition: service_healthy | ||
| ports: | ||
| - "8080:8080" | ||
| environment: | ||
| SPRING_DATASOURCE_URL: jdbc:mariadb://myapp-db:3306/springuser?createDatabaseIfNotExist=true | ||
| SPRING_DATASOURCE_USERNAME: springuser | ||
| SPRING_DATASOURCE_PASSWORD: springuser | ||
| SPRING_PROFILES_ACTIVE: dev | ||
| SPRING_MAIL_HOST: mailserver | ||
| SPRING_MAIL_PORT: 25 | ||
| SPRING_MAIL_PROPERTIES_MAIL_SMTP_AUTH: "false" | ||
| SPRING_MAIL_PROPERTIES_MAIL_SMTP_STARTTLS_ENABLE: "false" | ||
| SPRING_MAIL_PROPERTIES_MAIL_SMTP_STARTTLS_REQUIRED: "false" | ||
| healthcheck: | ||
| test: ["CMD", "wget", "-qO-", "http://localhost:8080/actuator/health"] | ||
| interval: 30s | ||
| timeout: 10s | ||
| retries: 5 | ||
|
|
||
| volumes: | ||
| mariadb-data: | ||
| maildata: | ||
| mailstate: | ||
| maillogs: | ||
| userdb: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
application-local.yml-exampleis currently invalid YAML:logging.level.org.springframework.webis set to the scalarDEBUGbut thenfilter:is indented beneath it. YAML scalars can’t have child keys, so Spring won’t be able to parse this file when someone copies it toapplication-local.yml. Restructure the logging section (e.g., makeweb:a map containingfilter, or flatten the key) so the example config is parseable.