Conversation
- Implemented gui-launcher module to enable command line execution of GUI
…t jar) to maven-jar-plugin (slim jar) - Corrected erroneous classPath in Gui commandlet
…modate new GUI commandlet
|
@hohwille I had following thoughts:
|
Coverage Report for CI Build 24361163360Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage decreased (-0.08%) to 70.386%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions12 previously-covered lines in 5 files lost coverage.
Coverage Stats
💛 - Coveralls |
Yes, |
No, since |
small fix in Gui.java Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
|
TODO: GO through the .workflow files for GitHu actions and update all java versions as discussed in the daily |
|
Currently experiencing issues with launching the IDEs from the GUI for some reason: This happens when clicking the open button on one of the IDEs, however the IDE still launches even with this error. |
…hanges got lost. Probably a shelving issue.) - fixed issues with MainClass path
|
I initially had trouble getting the gui commandlet to run locally. After debugging with @laim2003, we found that these commands get the program running locally: This is because the file is not yet included in the current release, so these manual steps are required for now. |
this was an issue with the classpath loader. changed the way the GUI is executed and now it seems to work (at least locally). Switched from using |
|
@hohwille just for my understanding: Right now, the pom.xml used to launch the gui (the flattened_pom from gui-launcher) is being copied into the |
…om.xml file does not exist.
…et-cleanhistory' into devonfw#1724-create-gui-commandlet-cleanhistory
| toolInstallRequest.setProcessContext(processContext); | ||
| toolInstallRequest.setRequested( | ||
| new ToolEditionAndVersion( | ||
| new ToolEdition("java", "25"), |
There was a problem hiding this comment.
what's that?
You are providing 25 as edition of Java - this can never work.
There was a problem hiding this comment.
How do I do this properly? Can I just put an empty string for the edition? Because if I want to use
java.installAsDependency(
(VersionRange) toolInstallRequest.getRequested().getVersion(),
toolInstallRequest
);
i have to declare the Version and Edition via ToolEditionAndVersion.
| "exec:exec", | ||
| "-Dexec.executable=java", | ||
| "-Dexec.classpathScope=compile", | ||
| "-Dexec.args=-classpath %classpath com.devonfw.ide.gui.AppLauncher" |
There was a problem hiding this comment.
KISS
| "-Dexec.args=-classpath %classpath com.devonfw.ide.gui.AppLauncher" | |
| "-Dexec.mainClass=com.devonfw.ide.gui.AppLauncher" |
There was a problem hiding this comment.
Using exec:java with exec.mainClass will lead to a problem:
Can't load log handler "com.devonfw.tools.ide.log.JulConsoleHandler"
java.lang.ClassNotFoundException: com.devonfw.tools.ide.log.JulConsoleHandler
When using exec:exec with -Dexec.executable=java and with defining the classpath manually, the class will be loaded correctly
pom.xml
Outdated
| <assembly.maven.plugin.version>3.7.1</assembly.maven.plugin.version> | ||
| <build.helper.maven.plugin.version>3.6.1</build.helper.maven.plugin.version> | ||
| <graalvm.version>24.2.1</graalvm.version> | ||
| <gui.relative_pom_path>gui-execution</gui.relative_pom_path> |
There was a problem hiding this comment.
Wouldn't just gui be enough (KISS)? Otherwise shouldn't it be named gui-launcher since we already introduced that name?
| <gui.relative_pom_path>gui-execution</gui.relative_pom_path> | |
| <gui.relative_pom_path>gui</gui.relative_pom_path> |
gui-launcher/pom.xml
Outdated
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <artifactId>maven-resources-plugin</artifactId> | ||
| <version>3.3.1</version> | ||
| <executions> | ||
| <execution> | ||
| <id>copy-gui-launcher-flattened-pom</id> | ||
| <phase>prepare-package</phase> | ||
| <goals> | ||
| <goal>copy-resources</goal> | ||
| </goals> | ||
| <configuration> | ||
| <outputDirectory>${project.build.directory}/package/gui</outputDirectory> | ||
| <resources> | ||
| <resource> | ||
| <directory>${project.basedir}</directory> | ||
| <includes> | ||
| <include>.flattened-pom.xml</include> | ||
| </includes> | ||
| </resource> | ||
| </resources> | ||
| </configuration> | ||
| </execution> | ||
| </executions> | ||
| </plugin> | ||
| </plugins> | ||
| </build> |
There was a problem hiding this comment.
Do we really need this?
It is just a copy of the same file in a different folder?
Why not referencing the original file in the antrun logic?
If I am not mistaken, the copy is not actually used by antrun but it already copies the source so IMHO this is pointless and can be removed without any other change.
| <build> | |
| <plugins> | |
| <plugin> | |
| <artifactId>maven-resources-plugin</artifactId> | |
| <version>3.3.1</version> | |
| <executions> | |
| <execution> | |
| <id>copy-gui-launcher-flattened-pom</id> | |
| <phase>prepare-package</phase> | |
| <goals> | |
| <goal>copy-resources</goal> | |
| </goals> | |
| <configuration> | |
| <outputDirectory>${project.build.directory}/package/gui</outputDirectory> | |
| <resources> | |
| <resource> | |
| <directory>${project.basedir}</directory> | |
| <includes> | |
| <include>.flattened-pom.xml</include> | |
| </includes> | |
| </resource> | |
| </resources> | |
| </configuration> | |
| </execution> | |
| </executions> | |
| </plugin> | |
| </plugins> | |
| </build> |
There was a problem hiding this comment.
i now moved this logic into the pom.xml of the ide-gui-launcher module. This way, this file will only be moved after the launcher module has been built
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
…et-cleanhistory' into devonfw#1724-create-gui-commandlet-cleanhistory
…her to the ide-gui-launcher module from ide-cli
This PR fixes #1724
Implemented changes:
Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalChecklist for tool commandlets
Have you added a new
«tool»as commandlet? There are the following additional checks:«tool»«TOOL»_VERSIONand«TOOL»_EDITIONare honored by your commandlet