Skip to content

#1799: Add support for file URL in GitUrl validation#1810

Open
AdemZarrouki wants to merge 3 commits intodevonfw:mainfrom
AdemZarrouki:feature/1799-support-file-url
Open

#1799: Add support for file URL in GitUrl validation#1810
AdemZarrouki wants to merge 3 commits intodevonfw:mainfrom
AdemZarrouki:feature/1799-support-file-url

Conversation

@AdemZarrouki
Copy link
Copy Markdown

@AdemZarrouki AdemZarrouki commented Apr 9, 2026

This PR fixes #1799

Implemented changes:

  • Extend Git URL support to include local repositories via file:// URLs

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 9, 2026

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Apr 9, 2026

Coverage Report for CI Build 24235973405

Coverage decreased (-0.002%) to 70.464%

Details

  • Coverage decreased (-0.002%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 15068
Covered Lines: 11068
Line Coverage: 73.45%
Relevant Branches: 6692
Covered Branches: 4265
Branch Coverage: 63.73%
Branches in Coverage %: Yes
Coverage Strength: 3.1 hits per line

💛 - Coveralls

@AdemZarrouki AdemZarrouki marked this pull request as ready for review April 9, 2026 14:17
@hohwille hohwille moved this from 🆕 New to Team Review in IDEasy board Apr 9, 2026
@hohwille hohwille added enhancement New feature or request git git version management tool integration labels Apr 9, 2026
@hohwille hohwille added this to the release:2026.04.002 milestone Apr 9, 2026
@jakozian jakozian moved this from Team Review to 👀 In review in IDEasy board Apr 10, 2026
@jakozian jakozian self-requested a review April 10, 2026 12:10
Copy link
Copy Markdown
Contributor

@jakozian jakozian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 👍 I tried to create a new project and filled in the request for the settings url with a local settings repository of my local drive and it accepted the file path as a valid git url, as you can see in the following screenshot:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request git git version management tool integration

Projects

Status: 👀 In review

Development

Successfully merging this pull request may close these issues.

Support file:// git URLs for local development

5 participants