Skip to content

Harden the GitHub client's edge cases #47

Closed

Description

@jamesconwaydev

The shared GitHub client handles the happy path and rate limits well. A handful of rarer answers still crash or misbehave:

  • a redirect with no Location, or a relative one;
  • Retry-After given as an HTTP date instead of seconds;
  • network errors that escape as raw URLErrors;
  • a GraphQL error entry that isn't a dict, and GraphQL RATE_LIMITED errors that aren't retried.

The test fake has a matching gap: a redirect cycle loops forever.

Done when each of these has a test and raises a GitHubError or RateLimited the callers already handle.

Activity

  1. added this to the v0.3 Polish milestone on Nov 6, 2026
  2. added
    priority: mediumNext in line once the high ones are done
    area: botThe Python bots that take submissions, count Likes and check health
    on Nov 6, 2026
  3. updated Area Bot and Effort M on Nov 6, 2026
  4. jamesconwaydev commented on Nov 6, 2026

    @jamesconwaydev
    CollaboratorAuthor

    Most of this landed in #199: a missing or relative Location, Retry-After as a date, network errors after retries now raised as GitHubError, and non-dict GraphQL errors. Still open: retrying a GraphQL RATE_LIMITED error instead of just raising.

  5. moved this from Todo to In Progress in DevStream Roadmapon Nov 6, 2026
  6. moved this from In Progress to Done in DevStream Roadmapon Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: botThe Python bots that take submissions, count Likes and check healthpriority: mediumNext in line once the high ones are done

    Type

    Fields

    Priority

    Medium

    Effort

    M

    Area

    Bot

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions