Repository navigation
fix: stop one IP-allow-listed repo from freezing Likes and rot - #193
Merged
Merged
Conversation
aquasecurity turned on an org IP allow list, so GitHub now refuses the App token on aquasecurity/trivy. The RepoMeta batch came back with one FORBIDDEN alias and Sync Likes raised on it, so no Like has been counted since 03:27 UTC. Rot would abort the same way on the REST 403. - graphql(allow_forbidden=True) lets through FORBIDDEN errors that name an alias; a pathless FORBIDDEN still raises. - Sync Likes keeps a hidden repo's last meta.json card. - Rot treats the IP allow list 403 as Undecided, so it is logged and tracked for review instead of stopping the weekly check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sync Likes has failed every run since 05:46 UTC:
One repo in a 50-repo RepoMeta batch was refused, and the whole run died with it. No Like has been counted since 03:27 UTC. Rot hits the same repo over REST and would abort the weekly check.
What changes:
graphql(allow_forbidden=True)lets through FORBIDDEN errors that name an alias. A FORBIDDEN with no path still raises, because that's the whole query refused.meta.jsoncard, so trivy keeps its stars and avatar.Tests: 540 pass, new cases for each of the three.