Repository navigation
test(reports): cover a hide whose entry left the list while queued - #200
Merged
jamesconwaydev merged 1 commit intoNov 6, 2026
Merged
Conversation
jamesconwaydev
approved these changes
Nov 6, 2026
jamesconwaydev
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, this is the one path that had no test, and I like that it checks the file is untouched too. Leave the two-reports race alone: a duplicate health check costs a few API calls and fixes itself, so a lock isn't worth it.
Collaborator
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #40. Two of its three parts were already on
mainwhen I picked it up, so this PR only adds the missing test.list-writesqueue before it starts runs no steps, so the report never getsneeds-review. The sweeper already re-dispatches any open report without that label after 10 minutes (test_sweep_redispatches_undecided_report). A job cancelled mid-run is parked by thecancelled()step. Nothing to change here.RECHECK_AFTER, the "had a health check in the last day" reply, with tests).main,applyexits 1, prints the reason to stderr, prints no branch and leavesentries.jsonalone. I checked that it fails if that branch returns 0.One gap I left alone: two dead reports on the same entry decided within a few seconds of each other can both queue a check, because the first dispatch hasn't appeared in the runs list yet. Closing that needs a lock or rot.py checking itself, which seemed too much for a rare duplicate check. Happy to do it if you want it.
Checks
python3 -m unittest discover -s scripts -t .passesnpm --prefix site testpasses (if you touchedsite/)npx prettier --check .passesdata/entries.jsonby hand (submissions go through the form)