Repository navigation
fix(submit): keep cleaned descriptions stable when cleaned again - #208
Merged
Merged
Conversation
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fuzzer caught this on #207's run. It's from #203, already on main.
validate_datacleans every stored description again and expects the same text back, and two inputs broke that:x. .?!becamex. ?on the first pass andx?on the second, because the!?strip ran before the dot strip. The whole run is now stripped at once.f\ufe0f\u200d❤the joiner was kept, since the lookbehind accepted any selector. Then the selector went, and the next pass dropped the joiner. A selector now counts only straight after an emoji.The fuzzer's inputs are in the fixed-point test, and 400k random strings of emoji, joiners and punctuation found no unstable result (5 on main). All 454 stored descriptions still validate.