Skip to content

fix(submit): keep cleaned descriptions stable when cleaned again - #208

Merged
jamesconwaydev merged 1 commit into
mainfrom
fix-description-fixed-point
Nov 6, 2026
Merged

jamesconwaydev merged 1 commit into
mainfrom
fix-description-fixed-point

Conversation

@jamesconwaydev

Copy link
Copy Markdown
Collaborator

The fuzzer caught this on #207's run. It's from #203, already on main. validate_data cleans every stored description again and expects the same text back, and two inputs broke that:

  • A dot and a space inside the trailing run. x. .?! became x. ? on the first pass and x? on the second, because the !? strip ran before the dot strip. The whole run is now stripped at once.
  • A joiner after a variation selector on a non-emoji. In f\ufe0f\u200d❤ the joiner was kept, since the lookbehind accepted any selector. Then the selector went, and the next pass dropped the joiner. A selector now counts only straight after an emoji.

The fuzzer's inputs are in the fixed-point test, and 400k random strings of emoji, joiners and punctuation found no unstable result (5 on main). All 454 stored descriptions still validate.

@jamesconwaydev
jamesconwaydev merged commit 6c21fea into main Nov 6, 2026
9 checks passed
@jamesconwaydev
jamesconwaydev deleted the fix-description-fixed-point branch November 6, 2026 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant