Repository navigation
fix(rot): wait out a rate limit instead of aborting the weekly check - #561
Merged
Merged
Conversation
At 5-10 REST calls per entry, the Monday check outruns the 5,000/hour budget somewhere past 700 entries. The client waits at most 600 s and then raises RateLimited, which aborted the whole plan every week. prepare now sleeps until the reset and retries that entry once. A reset more than an hour away, or a second limit on the same entry, still aborts, and the job's 120-minute timeout bounds the rest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At 5-10 REST calls per entry, the Monday health check outruns the 5,000/hour budget somewhere past 700 entries (455 today). The client waits at most 600 s, then raises
RateLimited, which abortedrot planwholesale; the sweep retries at most daily.preparenow sleeps until the reset and retries that entry once. A reset more than an hour away, or a second limit on the same entry, still aborts with nothing written. The job's 120-minute timeout bounds the total.Tests: new cases for wait-then-retry and the over-an-hour abort; the existing abort test still holds. 625 OK.