Repository navigation
fix(description): let a # follow a letter, so C# and F# repos can say so - #562
Merged
Merged
Conversation
Every # was rejected, so a C# library couldn't name its own language. A # straight after a letter is neither a heading nor an issue link, so only that one is allowed now; #123, ## and 1# still fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every
#was rejected, so a C# or F# repo couldn't name its own language in its description.A
#straight after a letter is neither a markdown heading nor an issue link, so that one is now allowed.#123,##and1#still fail. The error message now says so.After merge, the wiki's Submitting a Repo table needs the same change.
Tests: new case covering C#/F# and the still-rejected forms. Full suite OK.