Repository navigation
perf(site): draw the row Like icon from one shared symbol - #563
Merged
Merged
Conversation
Every leaderboard row inlined the full thumbsup path, 455 copies on the home page. The icon is now defined once per list and each row points at it with <use>, taking index.html from 784 KB to 512 KB.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every leaderboard row inlined the full octicon thumbsup path: 455 copies on the home page.
iconDefnow writes the icon once as a<symbol>beside the list, and each row draws it withiconUse(<svg><use href="#i-thumbsup"></svg>), keeping the same classes, size andaria-hidden. Same-document<use>needs nothing new from the CSP.index.html: 784 KB to 512 KB uncompressed. Category pages shrink in proportion. Build, prettier and unit tests pass.