Skip to content

perf(site): draw the row Like icon from one shared symbol - #563

Merged
jamesconwaydev merged 1 commit into
mainfrom
fix/site-shared-row-icon
Nov 18, 2026
Merged

jamesconwaydev merged 1 commit into
mainfrom
fix/site-shared-row-icon

Conversation

@jamesconwaydev

Copy link
Copy Markdown
Collaborator

Every leaderboard row inlined the full octicon thumbsup path: 455 copies on the home page.

iconDef now writes the icon once as a <symbol> beside the list, and each row draws it with iconUse (<svg><use href="#i-thumbsup"></svg>), keeping the same classes, size and aria-hidden. Same-document <use> needs nothing new from the CSP.

index.html: 784 KB to 512 KB uncompressed. Category pages shrink in proportion. Build, prettier and unit tests pass.

Every leaderboard row inlined the full thumbsup path, 455 copies on
the home page. The icon is now defined once per list and each row
points at it with <use>, taking index.html from 784 KB to 512 KB.
@jamesconwaydev
jamesconwaydev merged commit 8e91520 into main Nov 18, 2026
9 checks passed
@jamesconwaydev
jamesconwaydev deleted the fix/site-shared-row-icon branch November 18, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant