Repository navigation
fix(likes): start Trending on day one and stop publishing detection windows - #65
Merged
Merged
Conversation
…indows delta_7d now falls back to the oldest snapshot at least a day old when there is none from 7 days ago, and entries missing from the baseline count from 0 Likes. Burst and drip issue text no longer states the windows, counts or account-age cutoff.
Skip snapshot files with impossible or non-ASCII dates, fail closed when the chosen snapshot cannot be read, and make list_dir keep files only. Trending now needs delta_7d >= 5 and an entry listed for 7 days or added by seed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trending was empty for the first week after launch: with no snapshot from exactly 7 days ago every delta was 0, and a new repo had no baseline for 7 days. The baseline is now the 7-day snapshot if present, else the oldest snapshot at least a day old (no snapshot that old means deltas stay 0). Entries missing from the baseline count from 0 Likes, so delta_7d equals their Likes; their rank_delta_7d stays 0.
The burst and drip issue text also no longer states the detection windows, counts or the account-age cutoff, since that told people how to tune around the checks. The aggregate issue lists repos only.
Part of the v0.1 launch.