Repository navigation
feat(quality): accept CC content licenses for Learning & Resources - #66
Merged
Merged
Conversation
Entries in learning-resources may now carry CC0-1.0, CC-BY-4.0 or CC-BY-SA-4.0. Every other category still needs an OSI license, and the NonCommercial and NoDerivatives variants stay rejected everywhere. check_repo takes allowed_extra, applied to GitHub's spdx_id, the /license fallback, SPDX expressions, phrase detection and README names. decide(), the seed path and rot pass extra_licenses_for(category), so a CC-licensed learning-resources entry is no longer removed by rot.
…ings find_license reads one file at a time again, so an earlier non-OSI rejection can't be hidden by a later unreadable file. The CC hint is submit-only, README lines naming NC or ND variants no longer match, and the unused import is gone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Entries in the learning-resources category can now use CC0-1.0, CC-BY-4.0 or CC-BY-SA-4.0. Every other category still requires an OSI license, and the NonCommercial and NoDerivatives variants are rejected everywhere.
check_repo gets an allowed_extra parameter that counts in every detection path (spdx_id, the /license fallback, SPDX expressions, canonical-text phrases, README names). decide(), the seed path and rot pass the set for the entry's category, so a CC-licensed learning-resources entry is not removed by rot. When a CC license is found in another category, the not-found message says CC is accepted for Learning & Resources only.
Canonical texts for CC0, CC-BY, CC-BY-SA and CC-BY-NC (as a negative case) are vendored from spdx/license-list-data.
Part of the v0.1 launch.