Repository navigation
chore(ci): bump the actions-nonmajor group across 1 directory with 6 updates - #868
Conversation
Benchmark delta (vs
|
| size | recall@k (head Δ vs base) | MRR (head Δ vs base) | p99 (ms) |
|---|---|---|---|
| 50 | ✅ 0.5649 (+0.0000) | ✅ 0.4978 (+0.0000) | ✅ 0.508 (base 0.650) |
| 83 | ✅ 0.3825 (+0.0000) | ✅ 0.3242 (+0.0000) | ✅ 0.715 (base 1.205) |
| 1000 | ✅ 0.1475 (+0.0000) | ✅ 0.1456 (+0.0000) | ✅ 36.563 (base 47.855) |
Per-backend × per-size matrix
| backend | size | recall@k (Δ) | MRR (Δ) | p99 (ms) |
|---|---|---|---|---|
| bm25 | 100 | ✅ 0.3825 (+0.0000) | ✅ 0.3399 (+0.0000) | ✅ 6.678 (base 8.399) |
| bm25 | 500 | ✅ 0.2250 (+0.0000) | ✅ 0.2165 (+0.0000) | ✅ 32.343 (base 41.865) |
| bm25 | 1000 | ✅ 0.1575 (+0.0000) | ✅ 0.1525 (+0.0000) | ✅ 88.138 (base 112.387) |
| embedding_hashing | 100 | ✅ 0.5175 (+0.0000) | ✅ 0.4360 (+0.0000) | ✅ 8.600 (base 7.218) |
| embedding_hashing | 500 | ✅ 0.2700 (+0.0000) | ✅ 0.2674 (+0.0000) | ✅ 40.675 (base 43.171) |
| embedding_hashing | 1000 | ✅ 0.2000 (+0.0000) | ✅ 0.1931 (+0.0000) | ✅ 101.674 (base 102.979) |
| embedding_st | 100 | skipped (skipped: missing sentence-transformers) | — | — |
| embedding_st | 500 | skipped (skipped: missing sentence-transformers) | — | — |
| embedding_st | 1000 | skipped (skipped: missing sentence-transformers) | — | — |
| fuzzy | 100 | skipped (skipped: missing rapidfuzz) | — | — |
| fuzzy | 500 | skipped (skipped: missing rapidfuzz) | — | — |
| fuzzy | 1000 | skipped (skipped: missing rapidfuzz) | — | — |
| tfidf | 100 | ✅ 0.3825 (+0.0000) | ✅ 0.3220 (+0.0000) | ✅ 1.051 (base 1.193) |
| tfidf | 500 | ✅ 0.2325 (+0.0000) | ✅ 0.2314 (+0.0000) | ✅ 9.585 (base 10.803) |
| tfidf | 1000 | ✅ 0.1475 (+0.0000) | ✅ 0.1456 (+0.0000) | ✅ 36.665 (base 42.986) |
Context pipeline (per scenario)
| scenario | tokens | dropped | dedup |
|---|---|---|---|
| large_catalog | 1480 (base 1480, Δ+0) | 0 (base 0, Δ+0) | 0 (base 0, Δ+0) |
| long_conversation | 2500 (base 2500, Δ+0) | 0 (base 0, Δ+0) | 0 (base 0, Δ+0) |
| mixed_payload | 488 (base 488, Δ+0) | 0 (base 0, Δ+0) | 0 (base 0, Δ+0) |
| short_conversation | 487 (base 487, Δ+0) | 0 (base 0, Δ+0) | 0 (base 0, Δ+0) |
| stress_conversation | 6590 (base 6590, Δ+0) | 11 (base 11, Δ+0) | 4 (base 4, Δ+0) |
| tiny_payload | 256 (base 256, Δ+0) | 0 (base 0, Δ+0) | 0 (base 0, Δ+0) |
Numbers come from make benchmark / make benchmark-matrix.
Latency is hardware-dependent — treat the markers as a rough guide.
See benchmarks/scorecard.md for the full picture.
dgenio
left a comment
There was a problem hiding this comment.
Review — mergeable, but three of the six updates are on paths this PR's CI cannot exercise
Verdict: the diff is correct and the checks are green. Merge it after #869, and dispatch the release-path workflows once rather than twice.
The diff
Six SHA bumps across 14 workflow files, all mechanical, no inputs changed:
| Action | From → to | Where it runs |
|---|---|---|
actions/checkout |
9c091bb v7.0.0 → 3d3c42e v7.0.1 |
20 call sites, most exercised here |
github/codeql-action/{init,analyze,upload-sarif} |
5595cca → ff2f1c6 (both # v4) |
codeql.yml, ossf-scorecard.yml |
actions/attest-build-provenance |
0f67c3f v4.1.1 → 4d10147 v4.2.2 |
publish.yml only |
pypa/gh-action-pypi-publish |
cef2210 → dc37677 (both release/v1) |
publish.yml only |
docker/setup-buildx-action — not here, see #867 |
Three of those version comments do not move: # v4 twice and # release/v1. That is Dependabot behaving correctly under the SHA-pinning policy docs.yml records for #748 — the tag floats, the SHA is the pin — but it means the comment tells you nothing about what changed for the CodeQL and PyPI-publish bumps. For pypa/gh-action-pypi-publish specifically, that is the action holding the release path's trusted-publishing identity, so the SHA is the entire review surface. Status: confirmed from the diff.
CI is effectively green
17 of 18 checks pass. The one red is Python 3.15 pre-release, which is python-next.yml — continue-on-error: true, an advisory lane for the unreleased interpreter. It reports failure while the repository treats it as non-gating, so it is not a blocker here. Worth stating explicitly because a reader scanning for red will stop at it.
What the green does not cover
publish.yml—on: release/workflow_dispatch. Both the attestation and the PyPI-publish bumps live there and no check on this PR runs them.Release artifacts readyisrelease-readiness.yml, a different file.create-release.yml/prepare-release.yml— same category.deps-latest-weekly.yml—schedule/workflow_dispatch; two call sites, unexercised. This is the third PR this month whose CI silently doesn't cover that file.
The actions/checkout bump is the same edit in all of them, and it is exercised at seventeen other call sites, so the risk is low. The CodeQL bump is exercised (Analyze (python) passed). The two publish.yml-only bumps are not exercised by anything.
Ordering — this is the part worth acting on
publish.yml is currently on a broken release path: the last successful publish was v0.15.0 on 14 June, and #869 is the fix. This PR changes two actions in that same file, on different lines, so Git merges both cleanly and neither shows a conflict — but whichever lands second will not have been validated together with the other.
Merge #869 first, then this, then dispatch the release path once. Doing it the other way round means the first real exercise of the fixed release path also carries two unreviewed action SHAs, and a failure would not tell you which change caused it.
Same reasoning against #831 (setup-python 6.3.0 → 7.0.0) and #867 (setup-buildx in docker-publish.yml): all four touch overlapping files on non-overlapping lines. None conflict; the cost is only that each merge invalidates the others' CI evidence.
Incidental, and it settles a question on #831
python-next.yml already pins actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0 — the exact SHA #831 proposes rolling out everywhere. So that pin is not untested in this repository, though the lane it runs in is continue-on-error and targets 3.15, which makes it corroboration rather than proof.
Recommendation
Merge after #869. Then run deps-latest-weekly.yml and the release path via workflow_dispatch to cover the call sites PR CI never touches. Not approving — I did not author this, and the required approving review should come from someone who can act on the merge.
Generated by Claude Code
5367604 to
4383f26
Compare
…updates Bumps the actions-nonmajor group with 6 updates in the / directory: | Package | From | To | | --- | --- | --- | | [actions/checkout](https://github.com/actions/checkout) | `7.0.0` | `7.0.1` | | [github/codeql-action/init](https://github.com/github/codeql-action) | `4.37.6` | `4.37.8` | | [github/codeql-action/analyze](https://github.com/github/codeql-action) | `4.37.6` | `4.37.8` | | [github/codeql-action/upload-sarif](https://github.com/github/codeql-action) | `4.37.6` | `4.37.8` | | [actions/attest-build-provenance](https://github.com/actions/attest-build-provenance) | `4.1.1` | `4.2.2` | | [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) | `1.14.0` | `1.14.2` | Updates `actions/checkout` from 7.0.0 to 7.0.1 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@9c091bb...3d3c42e) Updates `github/codeql-action/init` from 4.37.6 to 4.37.8 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@5595cca...db488dd) Updates `github/codeql-action/analyze` from 4.37.6 to 4.37.8 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@5595cca...db488dd) Updates `github/codeql-action/upload-sarif` from 4.37.6 to 4.37.8 - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@5595cca...db488dd) Updates `actions/attest-build-provenance` from 4.1.1 to 4.2.2 - [Release notes](https://github.com/actions/attest-build-provenance/releases) - [Changelog](https://github.com/actions/attest-build-provenance/blob/main/RELEASE.md) - [Commits](actions/attest-build-provenance@0f67c3f...4d10147) Updates `pypa/gh-action-pypi-publish` from 1.14.0 to 1.14.2 - [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases) - [Commits](pypa/gh-action-pypi-publish@cef2210...dc37677) --- updated-dependencies: - dependency-name: actions/attest-build-provenance dependency-version: 4.2.2 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions-nonmajor - dependency-name: actions/checkout dependency-version: 7.0.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions-nonmajor - dependency-name: github/codeql-action/analyze dependency-version: 4.37.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions-nonmajor - dependency-name: github/codeql-action/init dependency-version: 4.37.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions-nonmajor - dependency-name: github/codeql-action/upload-sarif dependency-version: 4.37.7 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions-nonmajor - dependency-name: pypa/gh-action-pypi-publish dependency-version: 1.14.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: actions-nonmajor ... Signed-off-by: dependabot[bot] <support@github.com>
4383f26 to
37fb2be
Compare
Re-pins all setup-python uses to v7.0.0. v7 migrates the action to ESM and removes the `pip-install` input, which this repository never set; the manifest-fetch retry fix is a straight improvement for flaky setup steps. Conflicted with #868 after that merged. Resolved by taking main's newer actions/checkout v7.0.1 and this PR's setup-python v7.0.0 — one from each side, rather than a blanket ours/theirs. The repository is now internally consistent: 22 setup-python pins at v7.0.0 and 25 checkout pins at v7.0.1. All workflow YAML re-parsed after the resolution; CI green on 2438d4a.
Bumps the actions-nonmajor group with 6 updates in the / directory:
7.0.07.0.14.37.64.37.84.37.64.37.84.37.64.37.84.1.14.2.21.14.01.14.2Updates
actions/checkoutfrom 7.0.0 to 7.0.1Release notes
Sourced from actions/checkout's releases.
Changelog
Sourced from actions/checkout's changelog.
... (truncated)
Commits
3d3c42eprep v7.0.1 release (#2531)2880268escape values passed to --unset (#2530)12cd223trim only ascii whitespace for branch (#2521)62661c4skip running unsafe pr check if input is default (#2518)e8d4307Bump the minor-actions-dependencies group with 2 updates (#2499)631c942eslint 9 (#2474)4f1f4aeBump actions/upload-artifact from 4 to 7 (#2476)ba09753Bump actions/checkout from 6 to 7 (#2488)b9e0990Bump docker/login-action from 3.3.0 to 4.2.0 (#2479)e8cb398Bump docker/build-push-action from 6.5.0 to 7.2.0 (#2478)Updates
github/codeql-action/initfrom 4.37.6 to 4.37.8Release notes
Sourced from github/codeql-action/init's releases.
Changelog
Sourced from github/codeql-action/init's changelog.
... (truncated)
Commits
db488ddMerge pull request #4102 from github/update-v4.37.8-9ee088e131845f5bUpdate changelog for v4.37.89ee088eMerge pull request #4080 from github/henrymercer/studious-giggle1aef003Address review feedback on overlay disk flags508b83bMerge main into overlay minimum disk feature branchd97b342Merge pull request #4098 from github/mbg/permission-error-as-configuration-error47fa622MakeEACCESaConfigurationError45693ccRefactorENOSPCcheck intoisDiskConfigurationErrorfunctionc2fd8f5Merge pull request #4081 from github/mario-campos/version-cache-to-diskc56f48eLog unexpected conditions during caching CLI outputUpdates
github/codeql-action/analyzefrom 4.37.6 to 4.37.8Release notes
Sourced from github/codeql-action/analyze's releases.
Changelog
Sourced from github/codeql-action/analyze's changelog.
... (truncated)
Commits
db488ddMerge pull request #4102 from github/update-v4.37.8-9ee088e131845f5bUpdate changelog for v4.37.89ee088eMerge pull request #4080 from github/henrymercer/studious-giggle1aef003Address review feedback on overlay disk flags508b83bMerge main into overlay minimum disk feature branchd97b342Merge pull request #4098 from github/mbg/permission-error-as-configuration-error47fa622MakeEACCESaConfigurationError45693ccRefactorENOSPCcheck intoisDiskConfigurationErrorfunctionc2fd8f5Merge pull request #4081 from github/mario-campos/version-cache-to-diskc56f48eLog unexpected conditions during caching CLI outputUpdates
github/codeql-action/upload-sariffrom 4.37.6 to 4.37.8Release notes
Sourced from github/codeql-action/upload-sarif's releases.
Changelog
Sourced from github/codeql-action/upload-sarif's changelog.
... (truncated)
Commits
db488ddMerge pull request #4102 from github/update-v4.37.8-9ee088e131845f5bUpdate changelog for v4.37.89ee088eMerge pull request #4080 from github/henrymercer/studious-giggle1aef003Address review feedback on overlay disk flags508b83bMerge main into overlay minimum disk feature branchd97b342Merge pull request #4098 from github/mbg/permission-error-as-configuration-error47fa622MakeEACCESaConfigurationError45693ccRefactorENOSPCcheck intoisDiskConfigurationErrorfunctionc2fd8f5Merge pull request #4081 from github/mario-campos/version-cache-to-diskc56f48eLog unexpected conditions during caching CLI outputUpdates
actions/attest-build-provenancefrom 4.1.1 to 4.2.2Release notes
Sourced from actions/attest-build-provenance's releases.
Commits
4d10147Bump actions/attest from 4.2.0 to 4.2.1 in the actions-minor group (#862)e3fe62eBump the actions-minor group with 2 updates (#860)Updates
pypa/gh-action-pypi-publishfrom 1.14.0 to 1.14.2Release notes
Sourced from pypa/gh-action-pypi-publish's releases.
... (truncated)
Commits
dc37677Merge pull request #417 from trail-of-forks/ft/bump-deps8b2f234Bumppypi-attestationsandsigstore78b72dbMerge pull request #416 from takluyver/twine-v792f4d2aUpdate twine to v7ba38be9Merge pull request #408 from adisivaprasad/bump-setup-python-v6a6c5088Bump actions/setup-python from v5.6.0 to v6.2.0