Skip to content

Open Harness Server subcommands#1853

Open
SSharma-10 wants to merge 4 commits into
mainfrom
feat/agents-subcommands
Open

Open Harness Server subcommands#1853
SSharma-10 wants to merge 4 commits into
mainfrom
feat/agents-subcommands

Conversation

@SSharma-10
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread commands/agents.go
func Agents() *Command {
cmd := &Command{
Command: &cobra.Command{
Use: "agents",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep this under separate heading like we did for inference?

Comment thread commands/agents.go Outdated
if err != nil {
return err
}
fmt.Fprintf(c.Out, "Session created: %s\n", sess.SessionID)
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show the response using displayers not by fmt.Fprintf() where required

Copy link
Copy Markdown

@logwolvy logwolvy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming, relevant godo changes for sending agent spec yaml are done.
Please address the comments and we should be good to merge.

Comment thread commands/agents.go Outdated
"Start a new agent session",
`Creates a new agent session and prints its session id and status.

The `+"`"+`--agent`+"`"+` flag selects the agent kind (`+"`"+`claude-code`+"`"+` or `+"`"+`opencode`+"`"+`). The optional `+"`"+`--repo`+"`"+` flag passes a repo hint to the agent's initial environment.
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate flags are not required for v0, everything will be in the agent spec yaml.
Our backend will parse and use the fields, as required. You only have to ship the agent yaml.

Comment thread commands/agents.go
"Replays the full server-side event history for a session, then exits.",
Writer)

CmdBuilder(cmd, RunAgentsApprove, "approve <session-id> <request-id> <approve|reject|defer>",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am assuming the approval could also be processed from the TUI (in attached session), as shown in POC demo, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Comment thread commands/agents.go Outdated
},
}

cmdGitHub := CmdBuilder(cmd, RunAgentsAuthGitHub, "github",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to this for v0. Github token will be provided by the user in the agent spec/yaml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants