Repository navigation
fix(adk): keep ADK retry defaults in retry.when and count dynamic runs atomically - #7
Merged
Merged
Conversation
…s atomically retry.when replaced ADK's default predicate, so input validation errors were retried when the expression matched; they are now never retried. A DynamicFunc may run children concurrently, so DynamicEnv claims its max_iters budget atomically. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Dmytro Rashko <dimetron@me.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review follow-ups for kagent-dev#3344:
retry.whenno longer retriesworkflow.ErrInputValidation, matching ADK's default predicate.DynamicEnvclaims itsmax_itersbudget atomically, so concurrent child runs cannot exceed it.Tests:
go test -race ./adk/pkg/declarative/...,make -C go lint.