refactor: Remove pair potential overrides from CoreData#2351
Open
trisyoungs wants to merge 10 commits intodevelop2from
Open
refactor: Remove pair potential overrides from CoreData#2351trisyoungs wants to merge 10 commits intodevelop2from
trisyoungs wants to merge 10 commits intodevelop2from
Conversation
trisyoungs
force-pushed
the
dissolve2/last-water-energy-tests
branch
from
533eee0 to
3d8d51a
Compare
trisyoungs
added a commit
that referenced
this pull request
Apr 9, 2026
trisyoungs
added a commit
that referenced
this pull request
Apr 9, 2026
trisyoungs
added a commit
that referenced
this pull request
Apr 9, 2026
trisyoungs
added a commit
that referenced
this pull request
Apr 9, 2026
trisyoungs
added a commit
that referenced
this pull request
Apr 9, 2026
RobBuchananCompPhys
requested changes
Apr 14, 2026
Contributor
RobBuchananCompPhys
left a comment
RobBuchananCompPhys
left a comment
There was a problem hiding this comment.
This refactor looks good - however, my preference would be to utilise the TestGraph node tracking where possible going forward.
Co-authored-by: RobBuchanan <106311829+RobBuchananCompPhys@users.noreply.github.com>
trisyoungs
force-pushed
the
dissolve2/last-water-energy-tests
branch
from
0589f48 to
4eed7d7
Compare
RobBuchananCompPhys
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the
pairPotentialOverrides_storage fromCoreDatacompletely now that we have mirrored the functionality inDissolveGraph. Couple more refactored unit tests, and a few now-unnecessary old test files removed.