Repository navigation
Pinning SQLAlchemy to 2.0.x - #63
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe SQLAlchemy requirement now specifies versions 2.0.0 or later and below 2.1.0. ChangesSQLAlchemy Requirement
Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~5 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to SQLAlchemy is constrained to the 2.0.x range, matching the reported initialization incompatibility with 2.1; no actionable merge risk is evident from the supplied change. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@tonyskapunk thanks for this fix, it's most likely a problem with sqlalchemy-utils.
Could you add references to these 3 issues in your commit message and a quick comment in the requirements.txt file so that we can track their evolution and upgrade to SQLAlchemy 2.1 later ? |
fcharlier
left a comment
There was a problem hiding this comment.
Please track the reason for pinning as a comment in this file
SQLAlchemy-Utils does not have support for SQLAlchemy v2.1 yet causing issues while importing kvesteri/sqlalchemy-utils#829 kvesteri/sqlalchemy-utils#800 Should be solved by: kvesteri/sqlalchemy-utils#831 SQLAlchemy on 2.1 is causing this issue during db init: Traceback (most recent call last): File "/opt/dci-control-server/bin/dci-dbinit", line 27, in <module> from sqlalchemy_utils import functions as sa_funcs File "/usr/local/lib/python3.12/site-packages/sqlalchemy_utils/__init__.py", line 46, in <module> from .generic import generic_relationship # noqa ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/sqlalchemy_utils/generic.py", line 15, in <module> class GenericAttributeImpl(attributes.ScalarAttributeImpl): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: module 'sqlalchemy.orm.attributes' has no attribute 'ScalarAttributeImpl'. Did you mean: '_ScalarAttributeImpl'? Unable to init the DB. Exiting.
b891a3e to
e9298d1
Compare
|
recheck |
SQLAlchemy-Utils does not have support for SQLAlchemy v2.1 yet
causing issues while importing
kvesteri/sqlalchemy-utils#829
kvesteri/sqlalchemy-utils#800
Should be solved by: kvesteri/sqlalchemy-utils#831
SQLAlchemy on 2.1 is causing this issue during db init: Traceback (most recent call last): File "/opt/dci-control-server/bin/dci-dbinit", line 27, in <module> from sqlalchemy_utils import functions as sa_funcs File "/usr/local/lib/python3.12/site-packages/sqlalchemy_utils/__init__.py", line 46, in <module> from .generic import generic_relationship # noqa ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.12/site-packages/sqlalchemy_utils/generic.py", line 15, in <module> class GenericAttributeImpl(attributes.ScalarAttributeImpl): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ AttributeError: module 'sqlalchemy.orm.attributes' has no attribute 'ScalarAttributeImpl'. Did you mean: '_ScalarAttributeImpl'? Unable to init the DB. Exiting.Summary by CodeRabbit