Fix --key= empty string value consuming next arg in std.getopt#11008
Merged
thewilsonator merged 1 commit intodlang:masterfrom May 6, 2026
Merged
Fix --key= empty string value consuming next arg in std.getopt#11008thewilsonator merged 1 commit intodlang:masterfrom
thewilsonator merged 1 commit intodlang:masterfrom
Conversation
| (is(R == delegate) || is(Target == function)) && | ||
| !is(typeof(receiver("", ""))); | ||
| if (!isCallbackWithLessThanTwoParameters && !(val.length) && !incremental) | ||
| if (!isCallbackWithLessThanTwoParameters && val is null && !incremental) |
Contributor
There was a problem hiding this comment.
this breaks a unittest (at line 1036), presumably either it needs updating or we need to check for both val is null && !(val.length)
burner
force-pushed
the
issue_10791_getopt_empty_value
branch
from
598e93e to
da2bc7f
Compare
thewilsonator
approved these changes
May 6, 2026
Contributor
|
Thanks! |
Member
Author
|
@thewilsonator thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10791