Repository navigation
feature: jump to next unmarked file when marking - #378
Open
florian-lackner365 wants to merge 1 commit into
Open
florian-lackner365 wants to merge 1 commit into
florian-lackner365 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The navigation documentation overstates the modes covered, and the new tests do not verify that a nearer file above wins over an available farther file below.
2 open issues
What changed in this PR
This PR improves bottom-up file review by navigating to the nearest unmarked file after marking an entry, preferring downward movement when distances tie.
Changes:
- Adds nearest-unmarked navigation in normal mode when the hide-selected filter is disabled.
- Refactors test stubs and adds cases for navigation, tie-breaking, and unmarking.
- Documents the selection navigation behavior.
| File | Description |
|---|---|
lua/diffview/tests/functional/hide_selected_navigation_spec.lua |
Adds navigation tests and a reusable panel stub. |
lua/diffview/scene/views/diff/listeners.lua |
Replaces next-entry movement with nearest-unmarked lookup. |
doc/diffview.txt |
Describes cursor behavior after marking and unmarking. |
Review effort: Balanced
this simplifies workflows where you're reviewing from the bottom up, marking files as reviewed while you go.
florian-lackner365
force-pushed
the
feat/jump-to-next-unmarked
branch
from
November 16, 2026 09:39
9360c7d to
6325a7e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Hello friends!
Let me start by saying thank you for this awesome plugin. It's my daily driver for code review.
I often find myself reviewing the file list from the bottom up. I'm using
wto mark reviewed files as I go. Whenever I mark a file this way, the cursor jumps to the line after the marked file. Since I'm doing it bottom-up, I have to go up two lines every time.This PR implements a smarter logic: Jump to the closest unmarked file, preferring going down.
This keeps the base use-case functional while also supporting mine.
What do you think? Feel free to just close the PR if you don't feel like having it in
main👍