[Performance] Add option to not validate graph node count#7908
Open
GMNGeoffrey wants to merge 1 commit into
Open
[Performance] Add option to not validate graph node count#7908GMNGeoffrey wants to merge 1 commit into
GMNGeoffrey wants to merge 1 commit into
Conversation
This creates a device/host sync and can have a significant performance penalty. The argument here mirrors one on `create_block`. Seems like someone saw the same performance issue there (dmlc#7240).
Author
|
@mfbalin @frozenbugs @BarclayII PTAL (I can't add reviewers) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The node count validation forces a device/host sync and can have a significant performance penalty. The argument I added mirrors one on
create_blockadded in #7240. Seems like someone saw the same performance issue there.Checklist
Please feel free to remove inapplicable items for your PR.
All changes have test coverage. I did not find any existing coverage for this function