Make /bin/bash not hardcoded#204
Merged
Merged
Conversation
Use env-based bash shebangs for helper scripts and let make resolve bash through PATH. This keeps the project usable on systems where bash is not installed at /bin/bash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#!/usr/bin/env bashfor bash helper scriptsmakeresolvebashthroughPATHinstead of requiring/bin/bashAdapted from Jackson Brough's fork commit
4b410e4. The original commit also touchedflake.nix, but this branch does not include the fork's flake, so this PR only carries the portability changes for files already onmaster.Tests
make check