Repository navigation
Conversation
tkinterdnd2 converts a failed 'package require tkdnd' into a plain
RuntimeError('Unable to load tkdnd library.'). The existing three-attempt
retry in the Tk test fixtures only caught tk.TclError, so one transient
load failure on a Windows runner errored the test (master run 42625549084,
Windows / Python 3.12: 253 passed, 1 error).
Catch that specific RuntimeError in the same retry loop. Other
RuntimeErrors are re-raised unchanged.
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01THB2EyXE5J3ixR7k3GMr13
|
Welcome, and thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Der
CI-Workflow aufmasterist seitbfbcb9arot (Run 42625549084). Betroffen ist ein Job von 13:Pytest · windows-latest · Py 3.12mit253 passed, 5 skipped, 1 error.Ursache
Die Tk-Fixtures versuchen den Aufbau von
App()bereits dreimal, fangen dabei aber nurtk.TclError.tkinterdnd2wandelt ein fehlgeschlagenespackage require tkdndin einen einfachenRuntimeErrorum (TkinterDnD.py,_require). Dieser eine Fehlertyp ging deshalb am Retry vorbei. Die übrigen 12 Jobs und alle anderen Tests desselben Jobs waren grün; der Fehler ist ein sporadischer Ladefehler auf dem Runner, kein Produktfehler.Änderung
Nur Tests, kein Produktivcode:
tests/test_collection_export_lifecycle.pyundtests/test_ui_accessibility.py: Die vorhandene Retry-Schleife fängt zusätzlichRuntimeError, sofern die Meldungtkdndenthält. AndereRuntimeErrorwerden unverändert weitergereicht.Prüfung
py_compile).tkinterdnd2habe ich im Paketquelltext nachgelesen.tkinterin meiner Umgebung). Der Beleg ist die CI-Matrix dieses PRs.Grenze
Die Änderung macht den Lauf gegen einen einzelnen fehlgeschlagenen Ladeversuch robust. Warum
tkdndauf dem Windows-Runner gelegentlich nicht lädt, ist damit nicht geklärt. Schlägt das Laden dreimal hintereinander fehl, wird der Test intest_collection_export_lifecycle.pyweiterhin rot undtest_ui_accessibility.pyüberspringt wie bisher.Generated by Claude Code