Repository navigation
Conversation
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
lukisch
changed the title
lukisch
changed the title
lukisch
changed the title
The eleven-language regeneration dropped the n == 1 branch, so the RE-SWEEP regression test failed in CI. Use ICU plural in the DE/EN ARB catalogs and generated code, and point the static test at them. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THB2F2MDeT5zX4ahTjQx6w
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds eleven-language localization to Flutter, the Python desktop GUI and the readonly CLI, with complete README documentation in the same eleven languages. Flutter covers all 120 current API messages, including 30 previously missing playlist/tag messages. The desktop and CLI share the existing TranslationSystem catalog, now containing 364 keys.
The desktop language setting persists and takes effect after restart; MEDIABRAIN_LANG overrides it. CLI --lang can select a language per invocation. Translated dropdown labels keep their original itemData, query operators and stored filter codes. Arabic startup selects RTL direction. CLI lookups disable automatic catalog writes, retain SQLite mode=ro and preserve exit codes and user data.
Complete ES/ZH/JA/RU/FR/HI/AR/BN/PT READMEs join EN/DE. All eleven editions link each other and explain actual Flutter, desktop and CLI language selection. Native Windows file-dialog frames remain localized by Windows.
Validation: all eight source code blocks preserved in the nine new translations; original links and assets retained; link-parity smoke check passes for all eleven editions. Source-hash metadata tracks the synchronized English README. git diff --check passes.
Runtime validation on Flutter 3.44.0 / Dart 3.12.0: gen-l10n and offline dependency resolution succeed without a lockfile change; all 12 focused localization widget tests pass; focused static analysis reports no issues. Tests cover all eleven locale bundles, es-MX resolution, German fallback, placeholders, numeric interpolation, plural categories and Arabic RTL direction. Corrected literal ICU # output to interpolate the count. These checks do not establish visual device acceptance.
Python validation: all 30 targeted tests pass (25 CLI/translator and five offscreen Qt), covering readonly database behavior, exit codes, help, persisted language selection, stable dropdown/filter codes, translated standard buttons, regional locale resolution and German default. Changed Python modules compile successfully.
No visible-device layout or native-platform acceptance is claimed. The PR remains draft pending final acceptance.