Update Ghost readme with Apache2 setup#2280
Open
nicoandresr wants to merge 1 commit intodocker-library:masterfrom
Open
Update Ghost readme with Apache2 setup#2280nicoandresr wants to merge 1 commit intodocker-library:masterfrom
nicoandresr wants to merge 1 commit intodocker-library:masterfrom
Conversation
Adds the information about how to set up apache2 as a reverse proxy with the appropriate headers
nicoandresr
changed the title
yosifkit
requested changes
Feb 8, 2023
Member
yosifkit
left a comment
yosifkit
left a comment
There was a problem hiding this comment.
Any changes need to be made in the stack.yml or content.md since README.md is generated from them.
|
|
||
| Run `docker stack deploy -c stack.yml ghost` (or `docker-compose -f stack.yml up`), wait for it to initialize completely, and visit `http://swarm-ip:8080`, `http://localhost:8080`, or `http://host-ip:8080` (as appropriate). | ||
|
|
||
| ### Production mode with Apache2 as reverse proxy |
Member
There was a problem hiding this comment.
This is just a general reverse proxy setup, so not something we want to focus our very limited documentation on.
|
|
||
| ghost: | ||
| image: ghost:4-alpine | ||
| image: ghost:5 |
Member
There was a problem hiding this comment.
I'm not opposed to adding these updates to the docker-compose yaml file, but they do need to be in ghost/stack.yml since the ghost/README.md file is generated.
Technically, the compose file will work as-is on docker-compose while still preserving the image-defined volumes when creating new containers (thus preserving state), they just won't have "pretty" names to keep track of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the information about how to set up apache2 as a reverse proxy with the appropriate headers