dhi: add sfw variants#25254
Merged
Merged
Conversation
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
craig-osterhout
added
status/review
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
docker-agent
reviewed
Jun 3, 2026
docker-agent
left a comment
docker-agent
left a comment
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
The additions are well-written and follow the documentation style guide. The new Socket Firewall (SFW) variants section in both files is clear, correctly structured, and actionable. One minor URL verification note is left as an inline comment.
dvdksn
approved these changes
Jun 4, 2026
Contributor
dvdksn
left a comment
dvdksn
left a comment
There was a problem hiding this comment.
Looks good! Question/idea for a follow-up: would it make sense to have a matrix somewhere giving an overview of the different variants and their corresponding tag suffix?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added Socket Firewall variants description and example.
Added a vague image-specific variants description as a catch-all for the one-offs.
Related issues or tickets
ENGDOCS-3110
Reviews